fix(openapi-fetch): handle empty error responses when Content-Length header is stripped#2605
Merged
drwpow merged 2 commits intoopenapi-ts:mainfrom Feb 12, 2026
Conversation
…header is stripped When a proxy (like Cloudflare) strips the Content-Length header from an error response with no body, the client would return an empty string as the error value, which is falsy and causes issues when checking `if (error)`. This fix applies the same safe handling to error responses that already exists for success responses - when Content-Length is absent and the body is empty, return undefined for the error value to be consistent with 204 and Content-Length: 0 handling. Fixes openapi-ts#2574
👷 Deploy request for openapi-ts pending review.Visit the deploys page to approve it
|
🦋 Changeset detectedLatest commit: 37cf46f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
drwpow
reviewed
Feb 11, 2026
| expect(response.ok).toBe(false); | ||
| }); | ||
|
|
||
| test("handles success response with empty body when Content-Length header is stripped by proxy", async () => { |
drwpow
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2574
When a proxy (like Cloudflare) strips the
Content-Lengthheader from an error response with no body, the client would return an empty string as the error value. Since empty string is falsy, this causes issues when checkingif (error)- the code incorrectly treats it as "no error".Changes
This fix applies the same safe handling to error responses that already exists for success responses. When
Content-Lengthis absent and the body is empty:response.text()first to get the raw contentundefinedfor the error valueContent-Length: 0Testing
Added two new test cases in
delete.test.ts:All 442 tests pass including the new ones.
Reproduction