Thumbnails in backend#1708
Open
Arnei wants to merge 1 commit into
Open
Conversation
Currently when generating a thumbnail, we create it here in the frontend and then send it to the backend. With this patch, we instead send the timestamp it was generated from to the backend. The goal is to let the backend generate the actual thumbnail, instead of the frontend. This avoids quality issues when generating thumbnails from low resolution videos in the frontend. It also allows for respecting institituion specific thumbnail settings (e.g. encoding profiles). The downside is that this relies on workflow properties. As such, admins will have to adapt their workflows or thumbnail generation will be broken for them. This change should not impact the user experience of using the editor frontend.
|
This pull request is deployed at test.editor.opencast.org/1708/2026-06-03_15-05-20/ . |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THIS PR WILL BREAK THUMBNAIL GENERATION WITHOUT THE RELATED BACKEND PR: opencast/opencast#7698
Fixes #814.
Currently when generating a thumbnail, we create it here in the frontend and then send it to the backend. With this patch, we instead send the time stamp it was generated from to the backend.
The goal is to let the backend generate the actual thumbnail, instead of the frontend. This avoids quality issues when generating thumbnails from low resolution videos in the frontend. It also allows for respecting institution specific thumbnail settings (e.g. encoding profiles).
The downside is that this relies on workflow properties. As such, admins will have to adapt their workflows or thumbnail generation will be broken for
them.
This change should not impact the user experience of using the editor frontend.
How to test this
Requires changes in the backend. Can otherwise be tested as is.