fix: include registered extra props in PROPFIND request body#2726
Open
flash7777 wants to merge 1 commit into
Open
fix: include registered extra props in PROPFIND request body#2726flash7777 wants to merge 1 commit into
flash7777 wants to merge 1 commit into
Conversation
registerExtraProp() registered properties for response parsing but buildPropFindBody() never included them in the PROPFIND request XML. Extensions using registerExtraProp() would never receive their custom properties because the server was never asked for them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registerExtraProp()registered properties for response parsing butbuildPropFindBody()never included them in the PROPFIND request XML. Extensions usingregisterExtraProp()would never receive their custom properties because the server was never asked for them.Replaces #2721 (which had unrelated files).
Changes
builders.tsTest plan
registerExtraProp('oc:my.prop')<oc:my.prop/>