Skip to content

Implement TPM 1.2 EK flow#300

Merged
Chounoki merged 3 commits intoopenconfig:mainfrom
Chounoki:pr1
Apr 16, 2026
Merged

Implement TPM 1.2 EK flow#300
Chounoki merged 3 commits intoopenconfig:mainfrom
Chounoki:pr1

Conversation

@Chounoki
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements the TPM 1.2 EK challenge flow, introducing the TPMAsymCAContents structure and the necessary logic for challenge generation and verification. The changes also include transitioning to constant-time comparisons for sensitive data and updating gRPC error codes to better reflect state-related failures. Critical feedback identified the use of non-existent functions binary.Encode and binary.Decode, which must be replaced with binary.Write and binary.Read, respectively. Consequently, the bytes package needs to be re-imported to support these operations.

Comment thread server/service/service.go
Comment thread server/service/service_test.go
Comment thread server/service/service.go
@Chounoki Chounoki merged commit a17f65f into openconfig:main Apr 16, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants