Merged
Conversation
…ootz server in a new stream.
There was a problem hiding this comment.
Code Review
This pull request implements the TPM 1.2 EK challenge flow, introducing the TPMAsymCAContents structure and the necessary logic for challenge generation and verification. The changes also include transitioning to constant-time comparisons for sensitive data and updating gRPC error codes to better reflect state-related failures. Critical feedback identified the use of non-existent functions binary.Encode and binary.Decode, which must be replaced with binary.Write and binary.Read, respectively. Consequently, the bytes package needs to be re-imported to support these operations.
gmacf
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.