Skip to content

feat: Added tests for verifying course visibility options and schedule and details settings#162

Merged
cmltaWt0 merged 7 commits intoopenedx:masterfrom
raccoongang:advanced-settings-tests
Mar 17, 2026
Merged

feat: Added tests for verifying course visibility options and schedule and details settings#162
cmltaWt0 merged 7 commits intoopenedx:masterfrom
raccoongang:advanced-settings-tests

Conversation

@irin2811
Copy link
Copy Markdown
Contributor

@irin2811 irin2811 commented Jan 26, 2026

Smoke tests:

  • Test course visibility in catalog: none, about and both behavior (case: not enroled student on a course)
    Regression tests:
  • Set pacing to instructor paced
  • Set pacing to self paced
  • Set start date and end date
  • Set start time and end time

irin2811 and others added 6 commits December 30, 2025 11:25
@irin2811
feat: [CC-167] Schedule and Details settings
5f5468d 
Added based Schedule and Details Tests:
- [TC_AUTHOR_106] Set pacing to instructor paced
[TC_AUTHOR_107] Set pacing to self paced
[TC_AUTHOR_108] Set start date and end date
@irin2811
feat: [CC-167] code optimisation, fixing errors
384b88e 
move general api methods to separate file, fixing lint issues
@irin2811
feat: [CC-167] Schedule and Details settings tests
3c7797f 
Added tests for [TC_AUTHOR_109] Set start time and end time
@irin2811
feat: [CC-148] add test for advanced settings
1b7809d 
Added tests
- [TC_AUTHOR_133] Check course visibility "both"
- add methods for advanced settings tests
- fix lint issues
@irin2811
feat: [CC-148] fixing advanced settings logic +fix lint issues
7b02f18
@irin2811
Merge branch 'openedx:master' into advanced-settings-tests
d845650
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 26, 2026
@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented Jan 26, 2026

Thanks for the pull request, @irin2811!

This repository is currently maintained by @openedx/committers-cypress-e2e-tests.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Jan 26, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Jan 27, 2026
@mphilbrick211 mphilbrick211 requested a review from a team January 27, 2026 21:24
cmltaWt0
cmltaWt0 reviewed Feb 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cmltaWt0 cmltaWt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful work! 💟

I like API-driven test setup - using direct API calls to configure course dates/pacing/visibility instead of clicking through UI is fast and reliable, searchReindex integration correctly triggers search reindex after visibility changes so the course catalog reflects updates, pages structure, test coverage, preserved skipped tests etc.
It's really solid PR.

Let's just consider my suggestions to make it even better.

Comment thread cypress/support/apiHelpers.js
Comment thread cypress/support/apiHelpers.js
Comment thread cypress/e2e/studio/settings/testAdvancedSettings.cy.js Outdated
Comment thread cypress/pages/studio/settings/scheduleAndDetails.js Outdated
Comment thread cypress/pages/studio/settings/scheduleAndDetails.js Outdated
Comment thread cypress/e2e/studio/settings/testScheduleAndDetailsSettings.cy.js
cy.visit(`${baseMFEURL}/learning/course/${courseId}/home`)

// Verify that the course content is accessible
cy.contains('Begin your course today').should('be.visible')
Copy link
Copy Markdown
Contributor

@cmltaWt0 cmltaWt0 Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note for a future ourselves - do thing about localization.

Comment thread cypress/e2e/studio/settings/testAdvancedSettings.cy.js Outdated
Comment thread cypress/e2e/studio/settings/testAdvancedSettings.cy.js Outdated
Comment thread cypress/e2e/studio/settings/testScheduleAndDetailsSettings.cy.js Outdated
Comment thread cypress/e2e/studio/settings/testScheduleAndDetailsSettings.cy.js Outdated
@mphilbrick211 mphilbrick211 moved this from Ready for Review to In Eng Review in Contributions Feb 25, 2026
irin2811
irin2811 commented Mar 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@irin2811 irin2811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of the suggestions are fixed for advanced settings tests and schedule and details

cmltaWt0
cmltaWt0 approved these changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cmltaWt0 cmltaWt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! LGTM

@cmltaWt0 cmltaWt0 merged commit c4cb8e6 into openedx:master Mar 17, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from In Eng Review to Done in Contributions Mar 17, 2026
@irin2811 irin2811 deleted the advanced-settings-tests branch March 18, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmltaWt0 cmltaWt0 cmltaWt0 approved these changes

Assignees

@irin2811 irin2811

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@irin2811 @openedx-webhooks @cmltaWt0 @mphilbrick211