fix: a11y for screen readers on roles and permissions tabs#69
fix: a11y for screen readers on roles and permissions tabs#69jacobo-dominguez-wgu wants to merge 2 commits intoopenedx:masterfrom
Conversation
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #69 +/- ##
==========================================
+ Coverage 95.05% 95.12% +0.06%
==========================================
Files 45 46 +1
Lines 930 943 +13
Branches 178 178
==========================================
+ Hits 884 897 +13
Misses 44 44
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Adding aria labels and screen reader texts to icons and chips on roles and permission tabs to be accessible for screen readers.
Issues fixed:
1 - On the Roles tab, the Chips with disabled state were read as same as non disabled.
2 - On the Roles tab, the numbers after each role had no alt text associated with the 👤 icon.
3 - On the Permissions tab, the ✅ and ❌ icons were hidden entirely from screen readers.
It closes #48.
To test it, use an screen reader (example: VoiceOver on macOs, Sidepanel Chrome extension) to go over the described issues above and verify they are read correctly.