Refactor: Move courseTeam from redux store to react query#2888
Refactor: Move courseTeam from redux store to react query#2888ChrisChV merged 6 commits intoopenedx:masterfrom
courseTeam from redux store to react query#2888Conversation
|
Thanks for the pull request, @ChrisChV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
1569649 to
2aebc9c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2888 +/- ##
==========================================
+ Coverage 95.22% 95.37% +0.14%
==========================================
Files 1332 1332
Lines 30551 30594 +43
Branches 6678 6919 +241
==========================================
+ Hits 29093 29178 +85
+ Misses 1401 1347 -54
- Partials 57 69 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bradenmacdonald
left a comment
There was a problem hiding this comment.
|
@bradenmacdonald Thanks! I fixed that in 51a07ef |
bradenmacdonald
left a comment
There was a problem hiding this comment.
Thanks! One last request:
| const getErrorMessage = () => { | ||
| const errorObject = addUserMutation.error ?? editUserRoleMutation.error ?? deleteUserMutation.error; | ||
| // @ts-ignore | ||
| return errorObject?.response?.data?.error; |
There was a problem hiding this comment.
It would be good to have a default error message. Especially since other parts of the code have isFailed={errorMessage !== undefined}. So if the API returns an error in a different way than you're expecting, we need to still display a generic error instead of undefined.
| return errorObject?.response?.data?.error; | |
| return errorObject?.response?.data?.error ?? intl.formatMessage(messages.unknownError); |


Description
courseTeamfrom the redux store to React Query."Developer".
Supporting information
Testing instructions
Settings > Course Team.Other information
N/A
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'