Add course nav provides#148
Conversation
|
Thanks for the pull request, @diana-villalvazo-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
=======================================
Coverage 81.89% 81.89%
=======================================
Files 87 87
Lines 1121 1121
Branches 252 240 -12
=======================================
Hits 918 918
- Misses 196 198 +2
+ Partials 7 5 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arbrandes
left a comment
There was a problem hiding this comment.
Yes, that last frontend-base version comes with the new i18n stuff, already. :)
great, so its ok if i delete my i18/index file right? |
Not quite. The That will ensure when you run |
c1bf4a5 to
02c88e7
Compare
thanks Brian! i follow your PR and the Readme instructions 👍 |
brian-smith-tcril
left a comment
There was a problem hiding this comment.
The i18n parts all look right to me!
|
🎉 This PR is included in version 1.0.0-alpha.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
In order to frontend base provide Course Navigation Bar to our Instructor Dashboard MFE we need to add the proper config so it can be enabled.
Supporting Information
Related PR: openedx/frontend-base#106
Closes #22
Screenshot
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypes,defaultProps, andinjectIntlpatterns are not used in any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'