fix: remove obsolete mixed-decls from silenceDeprecations#683
Open
arbrandes wants to merge 1 commit intoopenedx:masterfrom
Open
fix: remove obsolete mixed-decls from silenceDeprecations#683arbrandes wants to merge 1 commit intoopenedx:masterfrom
arbrandes wants to merge 1 commit intoopenedx:masterfrom
Conversation
2 tasks
The mixed-decls deprecation became obsolete in Dart Sass 1.85.0, so silencing it now triggers its own warning in downstream MFE builds. Fixes openedx#682 Co-Authored-By: Claude <noreply@anthropic.com>
arbrandes
force-pushed
the
arbrandes/remove-obsolete-silence-deprecations
branch
from
f261f69 to
76d90a3
Compare
arbrandes
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
mixed-declsSass deprecation became obsolete in Dart Sass 1.85.0. Sincefrontend-buildpinssassat 1.85.1, silencing it now causes its own warning in downstream MFE builds. The othersilenceDeprecationsentries remain valid for the current Sass version.Fixes #682
Testing
To reproduce the problem, run
npm run devinfrontend-app-learning. You should see warnings like:To test the fix,
cdto your localfrontend-buildcheckout on this branch and pack a tarball:npm version 14.6.4 --no-git-tag-version && npm packThen install it in
frontend-app-learning:Run
npm run devagain and confirm themixed-declswarnings are gone.LLM usage notice
Built with assistance from Claude.