-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat: Enhance SAML provider name resolution & update redirect handling #38268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bra-i-am
wants to merge
1
commit into
openedx:master
Choose a base branch
from
eduNEXT:bc/enhance-saml-flow
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+51
−1
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_get_saml_provider_namewithin the middleware to construct a direct URL to the MFE with?duplicate_provider=.While this resolves the specific SAML case, I'm a bit concerned about extensibility and long-term maintainability. I'd like to share why I think it would be better to move this logic to a custom view (such asAccountSettingsRedirectView) that handles the error context in a more generic way.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, just a thought on this — I think we could improve the overall design by moving the redirect logic to a custom view (e.g.
AccountSettingsRedirectView) instead of handling it inside the middleware. Here's my reasoning:Centralizes redirect logic: The view would be responsible for reading error messages from
django.contrib.messages(or the session) and deciding how to pass them to the MFE. That way the middleware only needs to store the error (e.g. viamessages.error(...)) and doesn't need to know anything about URL construction.Extensible to any provider: Any backend (SAML, OAuth, LTI) can add a message with
extra_tags='social-auth'and the view will pick it up automatically — no need for provider-specific helper functions like_get_saml_provider_name.Cleaner separation of concerns: The middleware handles exceptions and stores errors; the view handles the redirect and forwards the error to the MFE. This makes both pieces easier to test and reason about independently.
Easier to evolve the MFE communication layer: If we ever decide to switch from URL params to an API endpoint, we only update the view — not the middleware. For example, the view could store the error in the session and the MFE could fetch it via a call to
/api/user/v1/tpa_errors/.