Forward addon -std=* from ADDON_CFLAGS into CXXFLAGS#8515
Open
GitBruno wants to merge 1 commit into
Open
Conversation
Appending addon CXXXFLAGS highest wins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward addon -std=* from ADDON_CFLAGS into CXXFLAGS
ADDON_CFLAGS are merged into OF_PROJECT_CFLAGS only, so addon
-std=gnu++20 (etc.) never reached C++ builds. Extract -std flags
from PROJECT_ADDONS_CFLAGS, dedupe against core flags, and apply
the last addon value to both CFLAGS and CXXFLAGS.