Added new map Stornogorm

[FishyB]

Fictional map based on Scotland & Hebrides

• [X ] I process any text displayed to the user through translateText() and I've added it to the en.json file
• [X ] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Discord: Fishbus

[CLAassistant]

All committers have signed the CLA.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 728b06cd-a58f-4b1f-bd4f-ea28081290d9

📥 Commits

Reviewing files that changed from the base of the PR and between 020a8fe and 1ab9e37.

📒 Files selected for processing (4)

• map-generator/main.go
• resources/lang/en.json
• src/core/game/Game.ts
• src/server/MapPlaylist.ts

🚧 Files skipped from review as they are similar to previous changes (3)

• src/core/game/Game.ts
• resources/lang/en.json
• src/server/MapPlaylist.ts

---

Walkthrough

Adds a new map "Stornogorm" with metadata and manifest files, registers it in map lists and playlist frequencies, and adds an English localization key. No control flow or runtime logic changes.

Changes

Cohort / File(s)	Summary
Map Generator Data map-generator/assets/maps/stornogorm/info.json, map-generator/main.go	Added stornogorm map metadata file and registered the map in the map-generator registry.
Map Manifest & Assets resources/maps/stornogorm/manifest.json	New manifest with multiple resolutions and 22 nation entries (coordinates, gb-sct flag, strength).
Game Map Types src/core/game/Game.ts	Added Stornogorm to GameMapType enum and included it in the fantasy mapCategories.
Localization resources/lang/en.json	Added map.stornogorm English translation: "Stornogorm".
Playlist Configuration src/server/MapPlaylist.ts	Registered Stornogorm with frequency weight 3 in map selection frequencies.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

Stornogorm sails into the game,
Isles and flags each bear a name,
Coordinates placed, the map is born,
Quiet files changed at early morn,
A new world set — take up the claim. 🗺️

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and accurately summarizes the main change: adding a new map called Stornogorm. It is concise, specific, and directly reflects the primary modification across all files in the changeset.
Description check	✅ Passed	The description is directly related to the changeset, explaining that a fictional map based on Scotland & Hebrides was added. It also documents the author's completion of required tasks (translation processing and testing).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (2)

map-generator/assets/maps/stornogorm/info.json (1)

1-3: Minor formatting inconsistency.

Line 2 has 3 spaces of indentation while the rest of the file uses 2 spaces. This is cosmetic but worth fixing for consistency.

🔧 Proposed fix

 {
-   "name": "stornogorm",
+  "name": "stornogorm",
   "nations": [

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@map-generator/assets/maps/stornogorm/info.json` around lines 1 - 3, The JSON
property line containing "name": "stornogorm" has 3 spaces of indentation while
the file uses 2-space indentation elsewhere; update that line so the "name" key
is indented with 2 spaces to match the rest of the file (ensure the "name" entry
and surrounding braces use consistent 2-space indentation).

resources/maps/stornogorm/manifest.json (1)

18-226: The strength field in nation entries is unused.

The Nation interface in src/core/game/TerrainMapLoader.ts only defines coordinates, flag, and name. The strength field will be silently ignored by the client code. While this is harmless, it adds unnecessary data to the manifest.

This is a minor inconsistency and won't break anything—just noting for awareness.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@resources/maps/stornogorm/manifest.json` around lines 18 - 226, The manifest
includes a unused "strength" property on each nation while the Nation interface
in src/core/game/TerrainMapLoader.ts only defines coordinates, flag, and name;
either remove the "strength" entries from
resources/maps/stornogorm/manifest.json (delete each "strength": 1) or update
the Nation type and any parsing in TerrainMapLoader (add strength: number to the
Nation interface and ensure loader reads/uses it) so the schema and data match.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@resources/lang/en.json`:
- Line 342: The JSON entry "stornogorm" uses a tab for indentation; replace the
leading tab with the same number of spaces used elsewhere in the file so the
"stornogorm": "Stornogorm" line matches the project's space-based indentation
(preserve surrounding spacing style and trailing commas/quotes exactly as in the
existing entries).

In `@src/core/game/Game.ts`:
- Line 205: The line containing GameMapType.Stornogorm uses a tab for
indentation which is inconsistent with the file's spaces; locate the occurrence
of GameMapType.Stornogorm in Game (e.g., in the array or enum usage) and replace
the leading tab with the same number of spaces used elsewhere in this file so
indentation matches the project's style.

---

Nitpick comments:
In `@map-generator/assets/maps/stornogorm/info.json`:
- Around line 1-3: The JSON property line containing "name": "stornogorm" has 3
spaces of indentation while the file uses 2-space indentation elsewhere; update
that line so the "name" key is indented with 2 spaces to match the rest of the
file (ensure the "name" entry and surrounding braces use consistent 2-space
indentation).

In `@resources/maps/stornogorm/manifest.json`:
- Around line 18-226: The manifest includes a unused "strength" property on each
nation while the Nation interface in src/core/game/TerrainMapLoader.ts only
defines coordinates, flag, and name; either remove the "strength" entries from
resources/maps/stornogorm/manifest.json (delete each "strength": 1) or update
the Nation type and any parsing in TerrainMapLoader (add strength: number to the
Nation interface and ensure loader reads/uses it) so the schema and data match.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4180e27f-392b-484c-96a3-bfb950157d23

📥 Commits

Reviewing files that changed from the base of the PR and between 84ae5fc and 020a8fe.

⛔ Files ignored due to path filters (4)

• map-generator/assets/maps/stornogorm/image.png is excluded by !**/*.png
• resources/maps/stornogorm/map.bin is excluded by !**/*.bin
• resources/maps/stornogorm/map16x.bin is excluded by !**/*.bin
• resources/maps/stornogorm/map4x.bin is excluded by !**/*.bin

📒 Files selected for processing (7)

• map-generator/assets/maps/stornogorm/info.json
• map-generator/main.go
• resources/lang/en.json
• resources/maps/stornogorm/manifest.json
• resources/maps/stornogorm/thumbnail.webp
• src/core/game/Game.ts
• src/server/MapPlaylist.ts

[evanpelle]

looks like there are some merge conflicts. please add a screenshot

[FishyB]

looks like there are some merge conflicts. please add a screenshot

Hey, It looks like another map had been added between forking and making a PR request. I have merged them so both maps exist.

Can you let me know what screenshot you need?

Cheers!

[FishyB]

Aegean map had been pushed to main, meaning both maps wanted to be added at the same time, which both require en.json/main.go/game.ts/mapplaylist.ts references to the map. Merged PR so both maps are referenced.

[FloPinguin]

Build is failing because of a json file fomatting issue