Skip to content

Added 1 new map 2000x2000px (Movtoc) to Fantasy section #3409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NightmareSHW wants to merge 1 commit into from
Closed

Added 1 new map 2000x2000px (Movtoc) to Fantasy section #3409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion resources/lang/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,8 @@
"niledelta": "Nile Delta",
"arctic": "Arctic",
"sanfrancisco": "San Francisco",
"aegean": "Aegean"
"aegean": "Aegean",
"movtoc": "Movtoc"
Comment on lines +345 to +346
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix the indentation here to clear CI.

Line 346 uses a tab while the rest of this JSON block uses spaces, which matches the current Prettier warning in CI. Reformat this entry and rerun prettier --check.

🧰 Tools
🪛 GitHub Actions: 🧪 CI

[warning] Prettier formatting issues found by 'npx prettier --check .'. Run 'npx prettier --write .' to fix.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@resources/lang/en.json` around lines 345 - 346, The "movtoc" entry uses a tab
for indentation; replace the tab with spaces to match the surrounding JSON
entries (same indentation as the "aegean" line) so the file is consistently
formatted, then save and re-run prettier --check; locate the "aegean" and
"movtoc" keys to make the correction.

},
"map_categories": {
"featured": "Featured",
Expand Down
140 changes: 140 additions & 0 deletions resources/maps/movtoc/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,140 @@
{
"map": {
"height": 2000,
"num_land_tiles": 2248304,
"width": 2000
},
"map16x": {
"height": 500,
"num_land_tiles": 135654,
"width": 500
},
"map4x": {
"height": 1000,
"num_land_tiles": 555450,
"width": 1000
},
"name": "movtoc",
"nations": [
{
"coordinates": [
631,
123
],
"flag": "",
"name": "Beckrim"
},
{
"coordinates": [
1295,
69
],
"flag": "",
"name": "Kachold"
},
{
"coordinates": [
1949,
269
],
"flag": "",
"name": "Armtis"
},
{
"coordinates": [
1589,
461
],
"flag": "",
"name": "Precksto Isle"
},
{
"coordinates": [
1055,
513
],
"flag": "",
"name": "Lemero"
},
{
"coordinates": [
79,
581
],
"flag": "",
"name": "Ghanori"
},
{
"coordinates": [
637,
851
],
"flag": "",
"name": "Dwarzen"
},
{
"coordinates": [
1235,
793
],
"flag": "",
"name": "Silvaz Coast"
},
{
"coordinates": [
1743,
961
],
"flag": "",
"name": "Benthakia"
},
{
"coordinates": [
1197,
1145
],
"flag": "",
"name": "Ethuluar"
},
{
"coordinates": [
767,
1253
],
"flag": "",
"name": "Kennikai"
},
{
"coordinates": [
1479,
1689
],
"flag": "",
"name": "Hethkop"
},
{
"coordinates": [
941,
1713
],
"flag": "",
"name": "Iafora"
},
{
"coordinates": [
367,
1843
],
"flag": "",
"name": "Thenarisar"
},
{
"coordinates": [
205,
1409
],
"flag": "",
"name": "Remoltan"
}
]
}
1,949 changes: 1,949 additions & 0 deletions resources/maps/movtoc/map.bin
View file
Open in desktop

Large diffs are not rendered by default.

124 changes: 124 additions & 0 deletions resources/maps/movtoc/map16x.bin
View file
Open in desktop

Large diffs are not rendered by default.

490 changes: 490 additions & 0 deletions resources/maps/movtoc/map4x.bin
View file
Open in desktop

Large diffs are not rendered by default.

Binary file added resources/maps/movtoc/thumbnail.webp
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 2 additions & 0 deletions src/core/game/Game.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ export enum GameMapType {
Arctic = "Arctic",
SanFrancisco = "San Francisco",
Aegean = "Aegean",
Movtoc = "Movtoc",
}

export type GameMapName = keyof typeof GameMapType;
Expand Down Expand Up @@ -203,6 +204,7 @@ export const mapCategories: Record<string, GameMapType[]> = {
GameMapType.Surrounded,
GameMapType.TradersDream,
GameMapType.Passage,
GameMapType.Movtoc,
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Use spaces here so Prettier passes.

Line 207 is indented with a tab, which matches the CI Prettier failure. Replace it with the same space indentation used by the surrounding array items.

🧰 Tools
🪛 GitHub Actions: 🧪 CI

[warning] Prettier formatting issues found by 'npx prettier --check .'. Run 'npx prettier --write .' to fix.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@src/core/game/Game.ts` at line 207, Line with the GameMapType enum entry
(GameMapType.Movtoc) is indented with a tab and fails Prettier; open
src/core/game/Game.ts and replace the tab indentation for the array item
containing GameMapType.Movtoc with the same space-based indentation used by the
surrounding items so spacing is consistent and Prettier passes (look for the
array of map types in the Game class or exported constant).

],
arcade: [
GameMapType.TheBox,
Expand Down
Loading