Add a simplification step to cpp region parsing.#3698
Closed
GuySten wants to merge 4 commits intoopenmc-dev:developfrom
Closed
Add a simplification step to cpp region parsing.#3698GuySten wants to merge 4 commits intoopenmc-dev:developfrom
GuySten wants to merge 4 commits intoopenmc-dev:developfrom
Conversation
695a20f to
030f36a
Compare
Merged
5 tasks
Contributor
Author
|
Closing in favor of #3730. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a simplification step to region parsing.
This is done to fix parsing of complicated region definitions that are written outside the python API.
Fixes #3685.
Checklist
I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)