Skip to content

Add a simplification step to cpp region parsing.#3698

Closed
GuySten wants to merge 4 commits intoopenmc-dev:developfrom
GuySten:region-simplification
Closed

Add a simplification step to cpp region parsing.#3698
GuySten wants to merge 4 commits intoopenmc-dev:developfrom
GuySten:region-simplification

Conversation

@GuySten
Copy link
Copy Markdown
Contributor

@GuySten GuySten commented Dec 26, 2025

Description

This PR adds a simplification step to region parsing.
This is done to fix parsing of complicated region definitions that are written outside the python API.

Fixes #3685.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@GuySten GuySten added the Bugs label Dec 26, 2025
@GuySten GuySten requested a review from paulromano December 26, 2025 04:29
@GuySten
Copy link
Copy Markdown
Contributor Author

GuySten commented Jan 15, 2026

Closing in favor of #3730.

@GuySten GuySten closed this Jan 15, 2026
@GuySten GuySten deleted the region-simplification branch January 22, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect logic in Cell definitions leading to incorrect definitions.

1 participant