Skip to content

Implement python tally types#3886

Draft
GuySten wants to merge 8 commits intoopenmc-dev:developfrom
GuySten:tally-refactor
Draft

Implement python tally types#3886
GuySten wants to merge 8 commits intoopenmc-dev:developfrom
GuySten:tally-refactor

Conversation

@GuySten
Copy link
Contributor

@GuySten GuySten commented Mar 18, 2026

Description

Currently we have different tally types on the cpp side only that are deduced according to the tally properties.
This make it so that alot of validation must be done on the cpp side.
This PR replace the python Tally class with a base TallyBase class and implement derived VolumeTally, SurfaceTally and PulseHeightTally classes with input validation

This change will support a future PointTally

Fixes # (issue)

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 18) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@GuySten GuySten changed the title Implement tally types Implement python tally types Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant