Mesh annotations #153
Merged
Mesh annotations #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulromano
reviewed
Nov 22, 2024
Contributor
paulromano
left a comment
paulromano
left a comment
There was a problem hiding this comment.
Thanks for this feature @pshriwise! One question below:
paulromano
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building a model with a mesh or applying a mesh, it can be useful to view that mesh on top of the geometry.
This PR adds mesh annotations, which allow users to view mesh boundaries without having performed a simulation first. This is possible thanks to the nice upgrade on mesh visualization from #134 and applies to all mesh types supported by OpenMC (regular, cylindrical, and unstructured meshes are shown below).