docs: add BMWK-EU funding notice to README#158
Conversation
Signed-off-by: Bastian Echterhölter <bastian.echterhoelter@sap.com> On-behalf-of: @SAP <bastian.echterhoelter@sap.com>
📝 WalkthroughWalkthroughREADME.md has been updated with the addition of a centered HTML image tag displaying the BMWE-EU funding logo after the Licensing section. This is purely a documentation content addition with no functional behavior changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
README.md (1)
57-57: Consider avoiding external hotlinking for a required compliance logo.For a mandatory notice, relying on a third-party URL can create a future broken/compliance gap if that asset moves. Prefer storing the logo in-repo (or an official, stable host controlled by your org) and referencing it locally.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` at line 57, Replace the external hotlinked logo in README.md by committing the image into the repository (e.g., assets/img/BMWK-EU.png) and update the <img> tag’s src to the local path; specifically locate the <img> element with alt="Bundesministerium für Wirtschaft und Energie (BMWE)-EU funding logo" and change its src from the external URL to the new in-repo relative path so the required compliance logo is served locally and won’t break if the external host changes.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Line 57: Update the image alt text to use the correct funding body
name/acronym: replace the current alt value "Bundesministerium für Wirtschaft
und Energie (BMWE)-EU funding logo" with "Bundesministerium für Wirtschaft und
Klimaschutz (BMWK-EU) funding logo" in the <img> tag so the alt attribute
matches the PR requirement and required wording.
---
Nitpick comments:
In `@README.md`:
- Line 57: Replace the external hotlinked logo in README.md by committing the
image into the repository (e.g., assets/img/BMWK-EU.png) and update the <img>
tag’s src to the local path; specifically locate the <img> element with
alt="Bundesministerium für Wirtschaft und Energie (BMWE)-EU funding logo" and
change its src from the external URL to the new in-repo relative path so the
required compliance logo is served locally and won’t break if the external host
changes.
|
|
||
|
|
||
|
|
||
| <p align="center"><img alt="Bundesministerium für Wirtschaft und Energie (BMWE)-EU funding logo" src="https://apeirora.eu/assets/img/BMWK-EU.png" width="400"/></p> |
There was a problem hiding this comment.
Fix funding body name/acronym mismatch in the notice text.
At Line 57, the notice says BMWE and “Wirtschaft und Energie,” but this PR’s requirement is BMWK-EU (Bundesministerium für Wirtschaft und Klimaschutz). Please align the alt text with the required wording to avoid compliance/documentation drift.
Proposed fix
-<p align="center"><img alt="Bundesministerium für Wirtschaft und Energie (BMWE)-EU funding logo" src="https://apeirora.eu/assets/img/BMWK-EU.png" width="400"/></p>
+<p align="center"><img alt="Bundesministerium für Wirtschaft und Klimaschutz (BMWK)-EU funding logo" src="https://apeirora.eu/assets/img/BMWK-EU.png" width="400"/></p>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <p align="center"><img alt="Bundesministerium für Wirtschaft und Energie (BMWE)-EU funding logo" src="https://apeirora.eu/assets/img/BMWK-EU.png" width="400"/></p> | |
| <p align="center"><img alt="Bundesministerium für Wirtschaft und Klimaschutz (BMWK)-EU funding logo" src="https://apeirora.eu/assets/img/BMWK-EU.png" width="400"/></p> |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@README.md` at line 57, Update the image alt text to use the correct funding
body name/acronym: replace the current alt value "Bundesministerium für
Wirtschaft und Energie (BMWE)-EU funding logo" with "Bundesministerium für
Wirtschaft und Klimaschutz (BMWK-EU) funding logo" in the <img> tag so the alt
attribute matches the PR requirement and required wording.
Summary
Summary by CodeRabbit