Add IntegrationAuthorization service and controller
#1793
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for integration authorization by introducing a new IntegrationAuthorization service and controller. The implementation enables users to generate long-lived tokens for third-party integrations like Slack Bot.
Key changes:
- Added
IntegrationNameenum and updated the schema to use it instead of a generic string - Implemented
TokenGeneratorPrincipaltype and correspondingTOKEN_GENERATORprincipal type for integration tokens - Created service layer and REST endpoint for generating and storing integration authorization tokens
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/shared/src/lib/integration-authorization/integration-authorization.ts | Added IntegrationName enum and updated schema to use enum instead of string |
| packages/shared/src/lib/authentication/model/principal.ts | Added TokenGeneratorPrincipal type for integration authorization |
| packages/shared/src/lib/authentication/model/principal-type.ts | Added TOKEN_GENERATOR principal type |
| packages/server/api/test/unit/integration-authorization/integration-authorization.service.test.ts | Added unit tests for integration authorization service |
| packages/server/api/src/app/integration-authorization/integration-authorization.service.ts | Implemented service for creating integration authorizations |
| packages/server/api/src/app/integration-authorization/integration-authorization.module.ts | Created module to register the controller |
| packages/server/api/src/app/integration-authorization/integration-authorization.controller.ts | Implemented REST endpoint for integration authorization |
| packages/server/api/src/app/authentication/context/access-token-manager.ts | Added method to generate token generator tokens with 3-month expiration |
| packages/server/api/src/app/app.ts | Registered the integration authorization module |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/server/api/src/app/integration-authorization/integration-authorization.controller.ts
Outdated
Show resolved
Hide resolved
packages/server/api/src/app/authentication/context/access-token-manager.ts
Show resolved
Hide resolved
…authorization-controller # Conflicts: # packages/shared/src/lib/integration-authorization/integration-authorization.ts
…ice, controller, tests, and database logic accordingly.
…ler updates for client-specific handling
…lidation in `refreshTokenService`
…authorization-controller
…edRefreshToken` type and enhance token handling logic
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes OPS-2987.