-
Notifications
You must be signed in to change notification settings - Fork 176
Allow the application to run without analytics #1802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e324dc5
Allow the application to run without analytics
maor-rozenfeld d1eaa5f
Fix lint
maor-rozenfeld 39536d8
Add cleanup for process.env modifications in analytics test (#1804)
Copilot 90a7591
Verify non-analytics routes remain registered when analytics disabled…
Copilot f56b7b3
Merge remote-tracking branch 'origin/main' into make-analytics-optional
maor-rozenfeld e19c855
Fix lint
maor-rozenfeld 0e4eeff
Merge branch 'main' into make-analytics-optional
maor-rozenfeld 5ff58e5
Fix merge conflicts and adjust FE conditional checks for including an…
cezudas ad3f8e9
Merge remote-tracking branch 'origin/main' into make-analytics-optional
maor-rozenfeld 339890d
Merge branch 'main' into make-analytics-optional
maor-rozenfeld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import { authenticationSession } from '@/app/lib/authentication-session'; | ||
| import { FlagId } from '@openops/shared'; | ||
| import { useMemo } from 'react'; | ||
| import { flagsHooks } from './flags-hooks'; | ||
|
|
||
| export const useHasAnalyticsAccess = (): boolean => { | ||
| const { data: isAnalyticsEnabled } = flagsHooks.useFlag<boolean | undefined>( | ||
| FlagId.ANALYTICS_ENABLED, | ||
| ); | ||
|
|
||
| const hasAnalyticsPrivileges = | ||
| authenticationSession.getUserHasAnalyticsPrivileges(); | ||
|
|
||
| return useMemo( | ||
| () => Boolean(isAnalyticsEnabled && hasAnalyticsPrivileges), | ||
| [isAnalyticsEnabled, hasAnalyticsPrivileges], | ||
| ); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conditional logic returns
undefinedwhen analytics is disabled, butsystem.get()already returnsundefinedwhen the value is not set. Consider simplifying to returnsystem.get(AppSystemProp.ANALYTICS_PUBLIC_URL) ?? undefinedwhen analytics is enabled, or verify if there's a scenario where the URL could be set but analytics disabled.