Skip to content

bugfix: parse_addr should use INADDR_ANY for "0.0.0.0", not INADDR_NONE #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
perfgao wants to merge 2 commits into
base: master
Choose a base branch
from
Open

bugfix: parse_addr should use INADDR_ANY for "0.0.0.0", not INADDR_NONE #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06b3993
bugfix: parse_addr should use INADDR_ANY for "0.0.0.0", not INADDR_NONE.
perfgao May 28, 2026
00560a8
tests: cover tcpsock/udpsock bind("0.0.0.0") wildcard regression.
perfgao May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ngx_stream_lua_util.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3720,7 +3720,7 @@ ngx_stream_lua_parse_addr(lua_State *L, u_char *text, size_t len,
#endif

if (len == 7 && memcmp(text, "0.0.0.0", 7) == 0) {
inaddr = INADDR_NONE;
inaddr = INADDR_ANY;
socklen = sizeof(struct sockaddr_in);
family = AF_INET;

Expand Down
39 changes: 39 additions & 0 deletions t/141-tcp-socket-bind.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,3 +224,42 @@ server {
127.0.0.1
--- no_error_log
[error]



=== TEST 6: upstream sockets bind 0.0.0.0 (wildcard, regression for INADDR_NONE bug)
--- stream_config
server {
listen 127.0.1.2:2986;
content_by_lua_block {
ngx.say(ngx.var.remote_addr)
}
}
--- stream_server_config
content_by_lua_block {
local sock = ngx.socket.tcp()

local ok, err = sock:bind("0.0.0.0")
if not ok then
ngx.log(ngx.ERR, "bind failed: ", err)
return
end

local ok, err = sock:connect("127.0.1.2", 2986)
if not ok then
ngx.log(ngx.ERR, "connect failed: ", err)
return
end

local line, err, part = sock:receive()
if line then
ngx.say(line)
else
ngx.log(ngx.ERR, err)
end
}

--- stream_response
127.0.0.1
--- no_error_log
[error]
37 changes: 37 additions & 0 deletions t/142-udp-socket-bind.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,3 +272,40 @@ server {

--- no_error_log
[error]



=== TEST 6: upstream sockets bind 0.0.0.0 (wildcard, regression for INADDR_NONE bug)
--- stream_config
server {
listen 127.0.1.2:2986 udp;
content_by_lua_block {
ngx.log(ngx.INFO, "udp bind address: " .. ngx.var.remote_addr)
}
}
--- stream_server_config
content_by_lua_block {
local sock = ngx.socket.udp()

local ok, err = sock:bind("0.0.0.0")
if not ok then
ngx.log(ngx.ERR, "bind failed: ", err)
return
end

local ok, err = sock:setpeername("127.0.1.2", 2986)
if not ok then
ngx.log(ngx.ERR, "setpeername failed: ", err)
return
end

local ok, err = sock:send("trigger")
if not ok then
ngx.log(ngx.ERR, err)
end
}

--- no_error_log
[error]
--- error_log
udp bind address: 127.0.0.1
Loading