Remove deprecated register keyword to enable C++17 compatibility with Apple Clang#1296
Open
czoido wants to merge 1 commit intoopenscenegraph:masterfrom
Open
Remove deprecated register keyword to enable C++17 compatibility with Apple Clang#1296czoido wants to merge 1 commit intoopenscenegraph:masterfrom
register keyword to enable C++17 compatibility with Apple Clang#1296czoido wants to merge 1 commit intoopenscenegraph:masterfrom
Conversation
sebhmg
added a commit
to MiraGeoscience/conan-center-index
that referenced
this pull request
Mar 21, 2026
Backport patches 0007-0011 from conan-center-index commit 0992b51 (conan-io#23704 Migrate/openscenegraph) to the Conan 1 recipe. Patches added: - 0007: fix MSVC with std C++17 (std::byte ambiguity with Windows SDK) Upstream: openscenegraph/OpenSceneGraph#1055 - 0008: replace std::mem_fun_ref (removed in C++17) Upstream: openscenegraph/OpenSceneGraph@8a0114a - 0009: replace std::auto_ptr in plugins (removed in C++17) Upstream: openscenegraph/OpenSceneGraph#1246 - 0010: replace std::ptr_fun in obj plugin (removed in C++17) Upstream: openscenegraph/OpenSceneGraph#1246 - 0011: remove deprecated register keyword (deprecated in C++17) Upstream: openscenegraph/OpenSceneGraph#1296 Source: conan-center-index@0992b51e2fe337e594f2c57bf6c01ee4d733165a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
This change is motivated by the fact that the
registerkeyword is deprecated as of C++17. I've removed it from ConfigLexer.cpp, which now allows us to build with Apple Clang using the C++17 standard.Thanks for taking a look at this!