Skip to content

assigned datablock to nested variable arrays#341

Closed
kalynstricklin wants to merge 1 commit intoopensensorhub:masterfrom
kalynstricklin:update-array-datablock
Closed

assigned datablock to nested variable arrays#341
kalynstricklin wants to merge 1 commit intoopensensorhub:masterfrom
kalynstricklin:update-array-datablock

Conversation

@kalynstricklin
Copy link
Copy Markdown

No description provided.

@alexrobin
Copy link
Copy Markdown
Member

Can you guys describe the problem that this is trying to solve? Please create an issue for it with detailed test cases so we can track why this was needed and add a UT for it.

Also, setting data on the component is not efficient so I wonder if there is a better way to do it.

@earocorn
Copy link
Copy Markdown

The problem is for nested variable-sized arrays. The getData() method will throw an exception instead of returning null, so it will throw an exception when trying to read a nested variable-sized array from a JSON string. I can create an issue and unit test that demonstrates the underlying issue.

@earocorn
Copy link
Copy Markdown

I added a unit test that demonstrates the issue in #342 . I believe you are right that there should be a better solution, but I think it would require a lot more changes to the parsers

@kalynstricklin
Copy link
Copy Markdown
Author

closing PR to move to @earocorn in #342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants