Skip to content

OCPBUGS-63472: add copy_network e2e test case for agent-tui network persistence#1870

Open
rwsu wants to merge 1 commit intoopenshift-metal3:masterfrom
rwsu:OCPBUGS-63472
Open

OCPBUGS-63472: add copy_network e2e test case for agent-tui network persistence#1870
rwsu wants to merge 1 commit intoopenshift-metal3:masterfrom
rwsu:OCPBUGS-63472

Conversation

@rwsu
Copy link
Contributor

@rwsu rwsu commented Mar 20, 2026

Add a new 'copy_network' AGENT_TEST_CASES scenario that validates static network connections created via the agent-tui during boot persist into the installed OS.

A NetworkManager keyfile is injected via SSH into the live environment on master_0 and master_1, simulating what a user would create via the agent-tui. The agent-tui exits quickly when connectivity to the release image succeeds, leaving no reliable window for key press automation, so SSH injection is used instead. The keyfile is in place before agent-set-host-copy-network-arg.service runs, so the service detects it and sets --copy-network per-host via the assisted-service REST API.

master_1 is intentionally included as a non-rendezvous node, which is the scenario the bug affected.

After installation, validate-copy-network.sh SSHes into both nodes and verifies the connection keyfile and nmcli entry are present, confirming that coreos-installer copied the keyfile into the installed OS.

To run:
export AGENT_E2E_TEST_SCENARIO=COMPACT_IPV4_DHCP
export AGENT_TEST_CASES='copy_network'

Assisted-by: Claude Sonnet 4.6 (1M context) noreply@anthropic.com

…ersistence

Add a new 'copy_network' AGENT_TEST_CASES scenario that validates static
network connections created via the agent-tui during boot persist into the
installed OS.

A NetworkManager keyfile is injected via SSH into the live environment on
master_0 and master_1, simulating what a user would create via the agent-tui.
The agent-tui exits quickly when connectivity to the release image succeeds,
leaving no reliable window for key press automation, so SSH injection is used
instead. The keyfile is in place before agent-set-host-copy-network-arg.service
runs, so the service detects it and sets --copy-network per-host via the
assisted-service REST API.

master_1 is intentionally included as a non-rendezvous node, which is the
scenario the bug affected.

After installation, validate-copy-network.sh SSHes into both nodes and verifies
the connection keyfile and nmcli entry are present, confirming that
coreos-installer copied the keyfile into the installed OS.

To run:
  export AGENT_E2E_TEST_SCENARIO=COMPACT_IPV4_DHCP
  export AGENT_TEST_CASES='copy_network'

Assisted-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci openshift-ci bot requested review from celebdor and zaneb March 20, 2026 19:46
@openshift-ci
Copy link

openshift-ci bot commented Mar 20, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign andfasano for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Mar 20, 2026

@rwsu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-compact-ipv4-iso-no-registry 1eb40f3 link false /test e2e-agent-compact-ipv4-iso-no-registry

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant