Skip to content

shellcheck fixes part 1#1898

Open
tdomnesc wants to merge 1 commit into
openshift-metal3:masterfrom
tdomnesc:shellcheck
Open

shellcheck fixes part 1#1898
tdomnesc wants to merge 1 commit into
openshift-metal3:masterfrom
tdomnesc:shellcheck

Conversation

@tdomnesc
Copy link
Copy Markdown
Contributor

No description provided.

@openshift-ci openshift-ci Bot requested review from celebdor and sadasu May 29, 2026 11:54
Copy link
Copy Markdown
Member

@zaneb zaneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"part 1 of 754" 😆
/approve

Comment thread 01_install_requirements.sh
Comment thread sanitychecks.sh Outdated
Comment thread utils.sh
sed -i -e "s%${IMAGE}%${IMAGE_MIRRORED}%g" "$ASSET_NEW"
done
done
done < <(find "${ASSETS_EXTRA_FOLDER}" \( -name \*.yml -or -name \*.yaml \) -print0)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yowza

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean here?

Comment thread utils.sh Outdated
Comment thread utils.sh Outdated
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2026
@tdomnesc
Copy link
Copy Markdown
Contributor Author

tdomnesc commented Jun 1, 2026

/retest

@tdomnesc
Copy link
Copy Markdown
Contributor Author

tdomnesc commented Jun 1, 2026

/test e2e-metal-ipi-bm e2e-metal-ipi-virtualmedia

@tdomnesc
Copy link
Copy Markdown
Contributor Author

tdomnesc commented Jun 1, 2026

/retest

8 similar comments
@tdomnesc
Copy link
Copy Markdown
Contributor Author

tdomnesc commented Jun 1, 2026

/retest

@tdomnesc
Copy link
Copy Markdown
Contributor Author

tdomnesc commented Jun 1, 2026

/retest

@tdomnesc
Copy link
Copy Markdown
Contributor Author

tdomnesc commented Jun 1, 2026

/retest

@tdomnesc
Copy link
Copy Markdown
Contributor Author

tdomnesc commented Jun 1, 2026

/retest

@tdomnesc
Copy link
Copy Markdown
Contributor Author

tdomnesc commented Jun 1, 2026

/retest

@tdomnesc
Copy link
Copy Markdown
Contributor Author

tdomnesc commented Jun 1, 2026

/retest

@tdomnesc
Copy link
Copy Markdown
Contributor Author

tdomnesc commented Jun 1, 2026

/retest

@tdomnesc
Copy link
Copy Markdown
Contributor Author

tdomnesc commented Jun 1, 2026

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants