Skip to content

Update prowgen #5018

Open
psalajova wants to merge 1 commit intoopenshift:mainfrom
psalajova:prowgen-add-gsm-project-config
Open

Update prowgen #5018
psalajova wants to merge 1 commit intoopenshift:mainfrom
psalajova:prowgen-add-gsm-project-config

Conversation

@psalajova
Copy link
Contributor

Updates prowgen with gsm-project-config arg (which ci-operator needs to successfully create GSM clients) and fixes missing enable-secrets-store-csi-driver=true flag in test.

@openshift-ci-robot
Copy link
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d0cdea37-ce4c-47db-8b3d-ea980a0ae8a8

📥 Commits

Reviewing files that changed from the base of the PR and between 3667f5e and 076202a.

📒 Files selected for processing (5)
  • pkg/api/constant.go
  • pkg/prowgen/jobbase.go
  • pkg/prowgen/podspec.go
  • pkg/prowgen/testdata/zz_fixture_TestGSMConfig_add_gsm_config_volume_and_mount.yaml
  • pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_multi_stage_test_with_CSI_enabled.yaml
💤 Files with no reviewable changes (1)
  • pkg/prowgen/jobbase.go

Walkthrough

This PR refactors GSM and CSI driver configuration by introducing new constants (GSMProjectConfigParameter and EnableCSIFlag) in the constants file, updating the podspec builder to register multiple parameters through a unified framework instead of direct argument calls, and removing redundant argument additions from the job base builder. Test fixtures validate the expected behavior with new configuration arguments.

Changes

Cohort / File(s) Summary
Constants Definition
pkg/api/constant.go
Adds two new public constants: GSMProjectConfigParameter (--gsm-project-config=/etc/gsm-config/gsm-project-config.yaml) and EnableCSIFlag (--enable-secrets-store-csi-driver=true), while maintaining existing GSM config constants with formatting alignment.
Podspec Builder Updates
pkg/prowgen/podspec.go
Extends GSMConfig() to register three parameters (csiEnabledParameter, gsmConfigParameter, gsmProjectConfigParameter) instead of one, with updated documentation reflecting the new --gsm-project-config flag and CSI driver enablement.
Job Base Builder Cleanup
pkg/prowgen/jobbase.go
Removes two explicit Arg() calls for enabling the secrets-store CSI driver, consolidating this logic into the parameter registration framework.
Test Fixtures
pkg/prowgen/testdata/zz_fixture_TestGSMConfig_add_gsm_config_volume_and_mount.yaml, pkg/prowgen/testdata/zz_fixture_TestNewProwJobBaseBuilderForTest_multi_stage_test_with_CSI_enabled.yaml
Updates test fixtures to include new CSI and GSM project config arguments in container specs, validating the refactored configuration approach.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable the changed files summary in the walkthrough.

Disable the reviews.changed_files_summary setting to disable the changed files summary in the walkthrough.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psalajova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2026
@psalajova
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

@psalajova: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 076202a link true /test images
ci/prow/breaking-changes 076202a link false /test breaking-changes
ci/prow/validate-vendor 076202a link true /test validate-vendor
ci/prow/checkconfig 076202a link true /test checkconfig
ci/prow/frontend-checks 076202a link true /test frontend-checks
ci/prow/unit 076202a link true /test unit
ci/prow/integration 076202a link true /test integration
ci/prow/format 076202a link true /test format
ci/prow/codegen 076202a link true /test codegen

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Prucek
Copy link
Member

Prucek commented Mar 17, 2026

this will be used by every ci-operator prowjob? We should think about using presets: #4994

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants