Conversation
…re-csi-driver flag
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (1)
WalkthroughThis PR refactors GSM and CSI driver configuration by introducing new constants (GSMProjectConfigParameter and EnableCSIFlag) in the constants file, updating the podspec builder to register multiple parameters through a unified framework instead of direct argument calls, and removing redundant argument additions from the job base builder. Test fixtures validate the expected behavior with new configuration arguments. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip You can disable the changed files summary in the walkthrough.Disable the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: psalajova The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
@psalajova: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
this will be used by every ci-operator prowjob? We should think about using presets: #4994 |
Updates prowgen with
gsm-project-configarg (which ci-operator needs to successfully create GSM clients) and fixes missingenable-secrets-store-csi-driver=trueflag in test.