Skip to content

Conversation

@machine424
Copy link
Contributor

@machine424 machine424 commented Jan 20, 2026

Needed for https://issues.redhat.com/browse/OCPBUGS-67003 so users adjust the config before upgrading.

4.19.22 contains the needed changes https://amd64.ocp.releases.ci.openshift.org/releasestream/4-stable/release/4.19.22

blocked-edges: Add PrometheusReservedExternalLabelsInUse risk for 4.20.0-4.20.10, except 4.20.7 as not part of candidate-4.20

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 20, 2026
@openshift-ci-robot
Copy link

@machine424: This pull request explicitly references no jira issue.

Details

In response to this:

Needed for https://issues.redhat.com/browse/OCPBUGS-67003 so users adjust the config before upgrading.

4.19.22 contains the needed changes https://amd64.ocp.releases.ci.openshift.org/releasestream/4-stable/release/4.19.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from PratikMahajan and fao89 January 20, 2026 07:53
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

@machine424: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hongkailiu
Copy link
Member

/lgtm
/approve

/hold

Do we want to wait for the fix in 4.20? Otherwise we will need to extend the risk to each 4.20.z in the future.
Free to cancel if you want our users to be aware of this now.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2026
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 30, 2026
@hongkailiu
Copy link
Member

/lgtm cancel

Just saw the new reply from Trevor in Slack.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 30, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: machine424
Once this PR has been reviewed and has the lgtm label, please ask for approval from hongkailiu. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants