-
Notifications
You must be signed in to change notification settings - Fork 65
NO-ISSUE: build-suggestions/4.20: Raise minor_min to 4.19.22 #8631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Needed for https://issues.redhat.com/browse/OCPBUGS-67003 so users adjust the config before upgrading.
|
@machine424: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Comment |
|
@machine424: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm /hold Do we want to wait for the fix in 4.20? Otherwise we will need to extend the risk to each 4.20.z in the future. |
|
/lgtm cancel Just saw the new reply from Trevor in Slack. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: machine424 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Needed for https://issues.redhat.com/browse/OCPBUGS-67003 so users adjust the config before upgrading.
4.19.22 contains the needed changes https://amd64.ocp.releases.ci.openshift.org/releasestream/4-stable/release/4.19.22
blocked-edges: Add PrometheusReservedExternalLabelsInUse risk for 4.20.0-4.20.10, except 4.20.7 as not part of candidate-4.20