OCPBUGS-78118: Add delete permission for Azure load balancers in credentials request#438
OCPBUGS-78118: Add delete permission for Azure load balancers in credentials request#438RadekManak wants to merge 2 commits intoopenshift:mainfrom
Conversation
The cloud-provider-azure CCM calls safeDeletePLS() when removing a Private Link Service (e.g. when a LoadBalancer Service with the azure-pls-create annotation is deleted). This function iterates over all PrivateEndpointConnections on the PLS and deletes each one before deleting the PLS itself, because Azure does not allow deleting a PLS that has active Private Endpoint connections from consumers. Without this permission, PLS cleanup fails when an external consumer has connected to the service via a Private Endpoint.
|
@RadekManak: This pull request references Jira Issue OCPBUGS-78118, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughTwo Azure permissions are added to the CredentialsRequest manifest file for the cloud-controller-manager-operator. The additions extend the spec.providerSpec.permissions list with Microsoft.Network/loadBalancers/delete and Microsoft.Network/privatelinkservices/privateEndpointConnections/delete capabilities. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/jira refresh |
|
@RadekManak: This pull request references Jira Issue OCPBUGS-78118, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@RadekManak: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.