Skip to content

OCPBUGS-78118: Add delete permission for Azure load balancers in credentials request#438

Open
RadekManak wants to merge 2 commits intoopenshift:mainfrom
RadekManak:feature-fix-missing-credential
Open

OCPBUGS-78118: Add delete permission for Azure load balancers in credentials request#438
RadekManak wants to merge 2 commits intoopenshift:mainfrom
RadekManak:feature-fix-missing-credential

Conversation

@RadekManak
Copy link
Contributor

No description provided.

The cloud-provider-azure CCM calls safeDeletePLS() when removing a
Private Link Service (e.g. when a LoadBalancer Service with the
azure-pls-create annotation is deleted). This function iterates over
all PrivateEndpointConnections on the PLS and deletes each one before
deleting the PLS itself, because Azure does not allow deleting a PLS
that has active Private Endpoint connections from consumers.

Without this permission, PLS cleanup fails when an external consumer
has connected to the service via a Private Endpoint.
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 17, 2026
@openshift-ci-robot
Copy link

@RadekManak: This pull request references Jira Issue OCPBUGS-78118, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 609f28e8-3194-4a1b-bbb8-50fda8510baa

📥 Commits

Reviewing files that changed from the base of the PR and between b108246 and c6f1319.

📒 Files selected for processing (1)
  • manifests/0000_26_cloud-controller-manager-operator_14_credentialsrequest-azure.yaml

Walkthrough

Two Azure permissions are added to the CredentialsRequest manifest file for the cloud-controller-manager-operator. The additions extend the spec.providerSpec.permissions list with Microsoft.Network/loadBalancers/delete and Microsoft.Network/privatelinkservices/privateEndpointConnections/delete capabilities.

Changes

Cohort / File(s) Summary
Azure CredentialsRequest Permissions
manifests/0000_26_cloud-controller-manager-operator_14_credentialsrequest-azure.yaml
Added two Azure permissions: Microsoft.Network/loadBalancers/delete and Microsoft.Network/privatelinkservices/privateEndpointConnections/delete to the spec.providerSpec.permissions list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from mdbooth and nrb March 17, 2026 12:16
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RadekManak
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 17, 2026
@openshift-ci-robot
Copy link

@RadekManak: This pull request references Jira Issue OCPBUGS-78118, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sunzhaohua2 March 17, 2026 12:18
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2026

@RadekManak: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants