OCPCLOUD-3287: Update to k8s 1.35.1 dependencies

[RadekManak]

No description provided.

[openshift-ci-robot]

@RadekManak: This pull request references OCPCLOUD-3287 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

Updates build tooling to golangci-lint v2, bumps Go to 1.25.0 and performs broad dependency upgrades across Kubernetes/OpenShift modules; adjusts Makefile HOME assignment and several test cleanup/assert patterns. One public function signature was changed in resource apply logic.

Changes

Cohort / File(s)	Summary
Build tooling & linter config Makefile, tools/tools.go, .golangci.yaml	Switches golangci-lint to v2 import/path and module usage; Makefile now unconditionally sets HOME = /tmp/kubebuilder-testing (removed conditional); .golangci.yaml adds version: 2, removes gosimple, and introduces a formatter block (goimports).
Dependency management go.mod	Bumps Go to 1.25.0 and performs a large set of dependency version upgrades (k8s.io/, openshift/, controller-runtime/tools, golangci-lint -> v2, and many indirects). Adds/changes replace directives (e.g., cloud-provider-vsphere). Significant manifest churn.
Tests & small cleanup assertions cmd/.../credentials_injector_test.go, pkg/config/config_test.go, pkg/controllers/status_test.go	Replaces plain defers with deferred asserts that check os.Remove/file.Close errors; in status_test.go tests now call reconciler Get wrapper (optr.Get(...)) instead of raw client optr.Client.Get(...).
Command main files — lint suppressions cmd/.../main.go, cmd/config-sync-controllers/main.go	Added // nolint:staticcheck comments to recorder initializations to suppress staticcheck warnings; no runtime behavior changes.
Controller logic / public API pkg/controllers/resourceapply/resourceapply.go	Changed public function signature: ApplyResource now accepts coreclientv1.Object instead of client.Object. Simplified needRecreate initialization logic in deployment/daemonset apply flows. This is a public API change requiring attention.
Other small edits assorted single-line import/path updates and minor test adjustments	Mostly import path updates (golangci-lint v2) and minor refactors across a few files; no additional public signatures modified.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[RadekManak]

/jira refresh

[openshift-ci-robot]

@RadekManak: This pull request references OCPCLOUD-3287 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[RadekManak]

/jira refresh

[openshift-ci-robot]

@RadekManak: This pull request references OCPCLOUD-3287 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@go.mod`:
- Line 295: Update the vulnerable module go.opentelemetry.io/otel/sdk from
v1.39.0 to v1.40.0 in go.mod (replace the existing go.opentelemetry.io/otel/sdk
v1.39.0 // indirect entry), then run the Go module commands to fetch and lock
the patched version (e.g., go get go.opentelemetry.io/otel/sdk@v1.40.0; go mod
tidy) and refresh vendoring (e.g., go mod vendor) so the patched v1.40.0 is
recorded and vendored.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b4b689fb-58d9-4915-a790-c98be70e8ecb

📥 Commits

Reviewing files that changed from the base of the PR and between b108246 and 4982c32.

⛔ Files ignored due to path filters (297)

• go.sum is excluded by !**/*.sum
• vendor/4d63.com/gocheckcompilerdirectives/checkcompilerdirectives/checkcompilerdirectives.go is excluded by !vendor/**, !**/vendor/**
• vendor/4d63.com/gochecknoglobals/checknoglobals/check_no_globals.go is excluded by !vendor/**, !**/vendor/**
• vendor/codeberg.org/chavacava/garif/.gitignore is excluded by !vendor/**, !**/vendor/**
• vendor/codeberg.org/chavacava/garif/LICENSE is excluded by !vendor/**, !**/vendor/**
• vendor/codeberg.org/chavacava/garif/README.md is excluded by !vendor/**, !**/vendor/**
• vendor/codeberg.org/chavacava/garif/constructors.go is excluded by !vendor/**, !**/vendor/**
• vendor/codeberg.org/chavacava/garif/decorators.go is excluded by !vendor/**, !**/vendor/**
• vendor/codeberg.org/chavacava/garif/doc.go is excluded by !vendor/**, !**/vendor/**
• vendor/codeberg.org/chavacava/garif/enums.go is excluded by !vendor/**, !**/vendor/**
• vendor/codeberg.org/chavacava/garif/io.go is excluded by !vendor/**, !**/vendor/**
• vendor/codeberg.org/chavacava/garif/models.go is excluded by !vendor/**, !**/vendor/**
• vendor/codeberg.org/polyfloyd/go-errorlint/LICENSE is excluded by !vendor/**, !**/vendor/**
• vendor/codeberg.org/polyfloyd/go-errorlint/errorlint/allowed.go is excluded by !vendor/**, !**/vendor/**
• vendor/codeberg.org/polyfloyd/go-errorlint/errorlint/analysis.go is excluded by !vendor/**, !**/vendor/**
• vendor/codeberg.org/polyfloyd/go-errorlint/errorlint/lint.go is excluded by !vendor/**, !**/vendor/**
• vendor/codeberg.org/polyfloyd/go-errorlint/errorlint/options.go is excluded by !vendor/**, !**/vendor/**
• vendor/codeberg.org/polyfloyd/go-errorlint/errorlint/printf.go is excluded by !vendor/**, !**/vendor/**
• vendor/dev.gaijin.team/go/exhaustruct/v4/LICENSE is excluded by !vendor/**, !**/vendor/**
• vendor/dev.gaijin.team/go/exhaustruct/v4/analyzer/analyzer.go is excluded by !vendor/**, !**/vendor/**
• vendor/dev.gaijin.team/go/exhaustruct/v4/analyzer/config.go is excluded by !vendor/**, !**/vendor/**
• vendor/dev.gaijin.team/go/exhaustruct/v4/internal/comment/cache.go is excluded by !vendor/**, !**/vendor/**
• vendor/dev.gaijin.team/go/exhaustruct/v4/internal/comment/directive.go is excluded by !vendor/**, !**/vendor/**
• vendor/dev.gaijin.team/go/exhaustruct/v4/internal/pattern/list.go is excluded by !vendor/**, !**/vendor/**
• vendor/dev.gaijin.team/go/exhaustruct/v4/internal/structure/fields-cache.go is excluded by !vendor/**, !**/vendor/**
• vendor/dev.gaijin.team/go/exhaustruct/v4/internal/structure/fields.go is excluded by !vendor/**, !**/vendor/**
• vendor/dev.gaijin.team/go/golib/LICENSE is excluded by !vendor/**, !**/vendor/**
• vendor/dev.gaijin.team/go/golib/e/doc.go is excluded by !vendor/**, !**/vendor/**
• vendor/dev.gaijin.team/go/golib/e/err.go is excluded by !vendor/**, !**/vendor/**
• vendor/dev.gaijin.team/go/golib/e/log.go is excluded by !vendor/**, !**/vendor/**
• vendor/dev.gaijin.team/go/golib/fields/dict.go is excluded by !vendor/**, !**/vendor/**
• vendor/dev.gaijin.team/go/golib/fields/doc.go is excluded by !vendor/**, !**/vendor/**
• vendor/dev.gaijin.team/go/golib/fields/field.go is excluded by !vendor/**, !**/vendor/**
• vendor/dev.gaijin.team/go/golib/fields/list.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/4meepo/tagalign/.gitignore is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/4meepo/tagalign/.goreleaser.yml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/4meepo/tagalign/options.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/4meepo/tagalign/tagalign.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Abirdcfly/dupword/README.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Abirdcfly/dupword/dupword.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/AdminBenni/iota-mixing/LICENSE is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/AdminBenni/iota-mixing/pkg/analyzer/analyzer.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/AdminBenni/iota-mixing/pkg/analyzer/flags/flags.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/AlwxSin/noinlineerr/.gitignore is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/AlwxSin/noinlineerr/.golangci.yml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/AlwxSin/noinlineerr/.goreleaser.yml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/AlwxSin/noinlineerr/LICENSE is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/AlwxSin/noinlineerr/README.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/AlwxSin/noinlineerr/noinlineerr.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/errname/pkg/analyzer/analyzer.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/nilnil/pkg/analyzer/analyzer.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/analyzer/analyzer.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/analyzer/checkers_factory.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/internal/checkers/bool_compare.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/internal/checkers/call_meta.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/internal/checkers/checker.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/internal/checkers/checkers_registry.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/internal/checkers/empty.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/internal/checkers/equal_values.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/internal/checkers/error_is_as.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/internal/checkers/error_nil.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/internal/checkers/expected_actual.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/internal/checkers/formatter.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/internal/checkers/go_require.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_basic_type.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_bool.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_comparison.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_context.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_diagnostic.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_http.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/internal/checkers/helpers_len.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/internal/checkers/len.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/internal/checkers/negative_positive.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/internal/checkers/require_error.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/internal/checkers/suite_method_signature.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/internal/checkers/suite_thelper.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/internal/checkers/useless_assert.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Antonboom/testifylint/internal/config/config.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/azcore/CHANGELOG.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/azcore/arm/internal/resource/resource_identifier.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/azcore/internal/exported/exported.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/azcore/internal/shared/constants.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/azcore/runtime/pager.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/azcore/runtime/poller.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/CHANGELOG.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/README.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/TOKEN_CACHING.MD is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/TROUBLESHOOTING.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/assets.json is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/azure_cli_credential.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/azure_developer_cli_credential.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/azure_powershell_credential.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/ci.yml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/default_azure_credential.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/developer_credential_util.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/developer_credential_util_nonwindows.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/developer_credential_util_windows.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/errors.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/managed-identity-matrix.json is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/test-resources-post.ps1 is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/test-resources.bicep is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/azidentity/version.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/CHANGELOG.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/README.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/autorest.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/models.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/CHANGELOG.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/LICENSE.txt is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/README.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/accounts_client.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/assets.json is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/autorest.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/blobcontainers_client.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/blobinventorypolicies_client.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/blobservices_client.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/build.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/ci.yml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/client_factory.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/constants.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/deletedaccounts_client.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/encryptionscopes_client.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/fileservices_client.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/fileshares_client.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/localusers_client.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/managementpolicies_client.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/models.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/models_serde.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/networksecurityperimeterconfigurations_client.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/objectreplicationpolicies_client.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/operations_client.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/options.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/privateendpointconnections_client.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/privatelinkresources_client.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/queue_client.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/queueservices_client.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/responses.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/skus_client.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/table_client.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/tableservices_client.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/taskassignmentinstancesreport_client.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/taskassignments_client.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/taskassignmentsinstancesreport_client.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/time_rfc1123.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/time_rfc3339.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/usages_client.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage/v2/version.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/AzureAD/microsoft-authentication-library-for-go/apps/confidential/confidential.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/AzureAD/microsoft-authentication-library-for-go/apps/internal/base/base.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/AzureAD/microsoft-authentication-library-for-go/apps/internal/base/storage/items.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/AzureAD/microsoft-authentication-library-for-go/apps/internal/base/storage/storage.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/AzureAD/microsoft-authentication-library-for-go/apps/internal/oauth/ops/accesstokens/accesstokens.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/AzureAD/microsoft-authentication-library-for-go/apps/internal/oauth/ops/authority/authority.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/AzureAD/microsoft-authentication-library-for-go/apps/public/public.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/BurntSushi/toml/README.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/BurntSushi/toml/decode.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/BurntSushi/toml/encode.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/BurntSushi/toml/error.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/BurntSushi/toml/lex.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/BurntSushi/toml/meta.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/BurntSushi/toml/parse.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Crocmagnon/fatcontext/pkg/analyzer/analyzer.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Djarvur/go-err113/.travis.yml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Djarvur/go-err113/comparison.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/Djarvur/go-err113/err113.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/GaijinEntertainment/go-exhaustruct/v3/analyzer/analyzer.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/GaijinEntertainment/go-exhaustruct/v3/internal/pattern/list.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/.gitignore is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/.golangci.yml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/.unqueryvet.example.yaml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/CONTRIBUTING.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/Dockerfile is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/LICENSE is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/README.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/RELEASE.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/Taskfile.yml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/action.yml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/analyzer.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/config.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/analyzer.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/concat.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/filter.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/fixes.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/format.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/n1detector.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/bun.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/ent.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/goqu.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/gorm.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/interface.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/jet.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/pgx.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/reform.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/rel.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/sqlboiler.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/sqlc.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/sqlx.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqlbuilders/squirrel.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/sqli_scanner.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/internal/analyzer/tx_leak_detector.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/pkg/config/config.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/MirrexOne/unqueryvet/schema.json is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/OpenPeeDeeP/depguard/v2/README.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/OpenPeeDeeP/depguard/v2/depguard.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/OpenPeeDeeP/depguard/v2/settings.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/.editorconfig is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/.gitignore is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/.golangci.yml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/.goreleaser.yml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/AGENTS.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/Bitfile is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/COPYING is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/Dockerfile is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/Justfile is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/README.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/biome.json is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/chroma.jpg is excluded by !**/*.jpg, !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/coalesce.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/colour.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/delegate.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/doc.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/emitters.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/formatter.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/formatters/api.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/formatters/html/html.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/formatters/json.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/formatters/svg/font_liberation_mono.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/formatters/svg/svg.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/formatters/tokens.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/formatters/tty_indexed.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/formatters/tty_truecolour.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/iterator.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexer.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/README.md is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/caddyfile.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/cl.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/dns.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/emacs.go is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/abap.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/abnf.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/actionscript.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/actionscript_3.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/ada.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/agda.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/al.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/alloy.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/angular2.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/antlr.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/apacheconf.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/apl.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/applescript.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/arangodb_aql.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/arduino.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/armasm.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/atl.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/autohotkey.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/autoit.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/awk.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/ballerina.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bash.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bash_session.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/batchfile.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/beef.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bibtex.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bicep.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/blitzbasic.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bnf.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/bqn.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/brainfuck.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/c#.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/c++.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/c.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/c3.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cap_n_proto.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cassandra_cql.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/ceylon.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cfengine3.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cfstatement.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/chaiscript.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/chapel.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cheetah.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/clojure.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cmake.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cobol.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/coffeescript.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/common_lisp.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/coq.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/core.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/crystal.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/css.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/csv.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cue.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/cython.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/d.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/dart.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/dax.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/desktop_entry.xml is excluded by !vendor/**, !**/vendor/**
• vendor/github.com/alecthomas/chroma/v2/lexers/embedded/devicetree.xml is excluded by !vendor/**, !**/vendor/**

📒 Files selected for processing (3)

• Makefile
• go.mod
• tools/tools.go

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@cmd/azure-config-credentials-injector/credentials_injector_test.go`:
- Around line 38-40: The temp files created as inputFile and outputFile in
credentials_injector_test.go are not closed before the deferred os.Remove, which
can cause deletion to fail on some platforms; after each os.CreateTemp call
(i.e., immediately after inputFile is created and after outputFile is created)
call inputFile.Close() and outputFile.Close() respectively so the defer that
removes the files succeeds; ensure you still defer os.Remove for cleanup and
only close the file handles (not remove) at those points.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a10025fb-fac8-4e05-bdb2-ef977921c49a

📥 Commits

Reviewing files that changed from the base of the PR and between 4982c32 and 20c0752.

📒 Files selected for processing (7)

• .golangci.yaml
• cmd/azure-config-credentials-injector/credentials_injector_test.go
• cmd/cluster-cloud-controller-manager-operator/main.go
• cmd/config-sync-controllers/main.go
• pkg/config/config_test.go
• pkg/controllers/resourceapply/resourceapply.go
• pkg/controllers/status_test.go

✅ Files skipped from review due to trivial changes (1)

• cmd/config-sync-controllers/main.go

[coderabbitai]

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

FILE="cmd/azure-config-credentials-injector/credentials_injector_test.go"

echo "Inspect temp file creation and cleanup calls:"
nl -ba "$FILE" | sed -n '29,55p'
rg -nP 'CreateTemp|\.Close\(|os\.Remove\(|os\.RemoveAll\(' "$FILE"

Repository: openshift/cluster-cloud-controller-manager-operator

Length of output: 200

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

FILE="cmd/azure-config-credentials-injector/credentials_injector_test.go"

# Check if file exists and show its relevant lines
if [ -f "$FILE" ]; then
  echo "=== Lines 29-55 of the file ==="
  sed -n '29,55p' "$FILE"
  echo ""
  echo "=== All CreateTemp, Close, and Remove calls ==="
  rg -n 'CreateTemp|\.Close\(|os\.Remove\(|os\.RemoveAll\(' "$FILE"
else
  echo "File not found: $FILE"
fi

Repository: openshift/cluster-cloud-controller-manager-operator

Length of output: 1239

---

🏁 Script executed:

#!/bin/bash
FILE="cmd/azure-config-credentials-injector/credentials_injector_test.go"

# Check the full file for all CreateTemp usages
echo "=== All CreateTemp calls in file ==="
rg -n 'CreateTemp' "$FILE"

# Get file size to see if we should review the whole thing
wc -l "$FILE"

Repository: openshift/cluster-cloud-controller-manager-operator

Length of output: 330

---

Close temp file handles before deferred os.Remove cleanup.

inputFile and outputFile are not closed after os.CreateTemp (lines 36, 42). On platforms with strict file handling (Windows, etc.), attempting to delete open files will fail, causing the deferred cleanup to fail and tests to become flaky.

Add inputFile.Close() after line 37 and outputFile.Close() after line 43.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@cmd/azure-config-credentials-injector/credentials_injector_test.go` around
lines 38 - 40, The temp files created as inputFile and outputFile in
credentials_injector_test.go are not closed before the deferred os.Remove, which
can cause deletion to fail on some platforms; after each os.CreateTemp call
(i.e., immediately after inputFile is created and after outputFile is created)
call inputFile.Close() and outputFile.Close() respectively so the defer that
removes the files succeeds; ensure you still defer os.Remove for cleanup and
only close the file handles (not remove) at those points.

[openshift-ci]

@RadekManak: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-ibmcloud-ovn	20c0752	link	false	/test e2e-ibmcloud-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[RadekManak]

/jira refresh

[openshift-ci-robot]

@RadekManak: This pull request references OCPCLOUD-3287 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.