Skip to content

CNTRLPLANE-2668:Migrating go standard etcd cases to ote#1575

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
gangwgr:migrate-ci
Mar 24, 2026
Merged

CNTRLPLANE-2668:Migrating go standard etcd cases to ote#1575
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
gangwgr:migrate-ci

Conversation

@gangwgr
Copy link
Copy Markdown
Contributor

@gangwgr gangwgr commented Mar 20, 2026

Summary

Migrated Go standard _test.go tests to the Ginkgo-based OpenShift Test Extension (OTE) framework.

Key Changes

  • Refactored File Structure: Renamed *_test.go files to *.go to allow integration with the OTE package.
  • Ginkgo Integration: Added g.Describe and g.It registration blocks across all migrated files.
  • Interface Abstraction: Updated test signatures from *testing.T to testing.TB to support the OTE bridge.
  • Cleanup: Removed main_test.go as test entry points are now handled by Ginkgo.

Note

Since testing.TB does not support t.Run(), subtests (specifically in etcdctl.go) have been refactored into standard loops for compatibility.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 20, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c6060c2e-06fd-4a4f-a69d-162610bef56a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 20, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2026
@gangwgr gangwgr changed the title Migrating go standard cases to ote [WIP]Migrating go standard cases to ote Mar 20, 2026
@gangwgr gangwgr marked this pull request as ready for review March 20, 2026 13:37
@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Mar 20, 2026

/pipeline required

@openshift-ci openshift-ci Bot requested review from hasbro17 and ironcladlou March 20, 2026 13:41
@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Mar 20, 2026

/test e2e-gcp-operator-disruptive

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Mar 20, 2026

/test e2e-gcp-operator

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Mar 20, 2026

/test images

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Mar 20, 2026

/test e2e-metal-ipi-ovn-ipv6

1 similar comment
@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Mar 20, 2026

/test e2e-metal-ipi-ovn-ipv6

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Mar 23, 2026

/retest-required

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Mar 23, 2026

/retest

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Mar 23, 2026

/test e2e-metal-ipi-ovn-ipv6

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Mar 24, 2026

/test okd-scos-images

@gangwgr gangwgr changed the title [WIP]Migrating go standard cases to ote Migrating go standard cases to ote Mar 24, 2026
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 24, 2026
@gangwgr gangwgr changed the title Migrating go standard cases to ote Migrating go standard etcd cases to ote Mar 24, 2026
@dusk125
Copy link
Copy Markdown
Contributor

dusk125 commented Mar 24, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 24, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, gangwgr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 24, 2026

@gangwgr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gangwgr gangwgr changed the title Migrating go standard etcd cases to ote CNTRLPLANE-2668:Migrating go standard etcd cases to ote Mar 24, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 24, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 24, 2026

@gangwgr: This pull request references CNTRLPLANE-2668 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

Migrated Go standard _test.go tests to the Ginkgo-based OpenShift Test Extension (OTE) framework.

Key Changes

  • Refactored File Structure: Renamed *_test.go files to *.go to allow integration with the OTE package.
  • Ginkgo Integration: Added g.Describe and g.It registration blocks across all migrated files.
  • Interface Abstraction: Updated test signatures from *testing.T to testing.TB to support the OTE bridge.
  • Cleanup: Removed main_test.go as test entry points are now handled by Ginkgo.

Note

Since testing.TB does not support t.Run(), subtests (specifically in etcdctl.go) have been refactored into standard loops for compatibility.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gangwgr
Copy link
Copy Markdown
Contributor Author

gangwgr commented Mar 24, 2026

/verified by @gangwgr and ci runs

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 24, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@gangwgr: This PR has been marked as verified by @gangwgr and ci runs.

Details

In response to this:

/verified by @gangwgr and ci runs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit b91eb44 into openshift:main Mar 24, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants