[4.21] CNF-18941: perfprof: enable exec-cpu-affinity by default#1484
[4.21] CNF-18941: perfprof: enable exec-cpu-affinity by default#1484shajmakh wants to merge 5 commits intoopenshift:release-4.21from
Conversation
For High-performance configuration, cri-o started supporting exec-cpu-affinity feature and when configured to `first` it provides the ability for exec process to be pinned to the first CPU from the shared-CPUs IF set or to the first one from the islolated set. (see cri-o/cri-o@4dd7fb9) In performance profile, we want to enable this high-performance feature by default, and disable it (legacy) it provides an annotation option. The annotation is there just as a backup in case of bugs getting reported by the consequences of this feature enablement, and should be removed in 2 releases. Run `./hack/render-sync.sh` to update the (no-cluster) e2e tests expected outputs. Signed-off-by: Shereen Haj <shajmakh@redhat.com> (cherry picked from commit 370d4a3)
The annotation tells crun to manage container's cgroup using the systemd default subgroup behavior. This is meant to reduce the nested cgroups so the container cgroup is placed on the pod/system clice (the parent) rather than creating a cgroup per container. Signed-off-by: Shereen Haj <shajmakh@redhat.com> (cherry picked from commit 16d02b2)
openshift-ci-robot
added
the
jira/valid-reference
|
@shajmakh: This pull request references CNF-18941 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.21.z" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can make CodeRabbit's review stricter and more nitpicky using the `assertive` profile, if that's what you prefer.Change the |
|
@shajmakh: This pull request references CNF-18941 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.21.z" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shajmakh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Introduce pods.DeleteAndSync helper (with client.Client parameter) and replace all local deleteTestPod functions and inline Get+Delete+WaitForDeletion patterns across functest suites with calls to this shared utility. Assisted-by: Cursor v2.3.37 AIA Attribution: AIA Primarily human, Stylistic edits, Human-initiated, Reviewed Signed-off-by: Shereen Haj <shajmakh@redhat.com> (cherry picked from commit d48bd52)
Add e2e tests to verify exec-cpu-affinity behavior across cpu_management, updating_profile, and mixedcpus suites. Tests verify that exec processes are pinned to the correct exclusive, shared, or isolated CPU sets based on pod QoS class and container resource requests. Assisted-by: Cursor v2.3.37 AIA Attribution: AIA Primarily human, Stylistic edits, Human-initiated, Reviewed v1.0 Signed-off-by: Shereen Haj <shajmakh@redhat.com> (cherry picked from commit 47d606470002f77e4e20ef3339a9fae196c26447)
Add unit tests for functions in resources helper package for tests. Assisted-by: Cursor v1.2.2 AI-Attribution: AIA Entirely AI, Human-initiated, Reviewed, Cursor v1.2.2 v1.0 Signed-off-by: Shereen Haj <shajmakh@redhat.com> (cherry picked from commit 3604b53)
shajmakh
force-pushed
the
backport-execcpuaff-4.21
branch
from
245775d to
d3b885a
Compare
|
@shajmakh: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
For High-performance configuration, cri-o started supporting exec-cpu-affinity feature and when configured to first it provides the ability for exec process to be pinned to the first CPU from the shared-CPUs IF set or to the first one from the islolated set.
(see cri-o/cri-o@4dd7fb9)
In performance profile, we want to enable this high-performance feature by default, and disable it (legacy) it provides an annotation option.
The annotation is there just as a backup in case of bugs getting reported by the consequences of this feature enablement, and should be removed in 3 releases.
manual backport of: #1426, #1432