OCPBUGS-77026: DNS optimization, add trailing dots#1112
OCPBUGS-77026: DNS optimization, add trailing dots#1112jotak wants to merge 1 commit intoopenshift:mainfrom
Conversation
Update getProxyServiceURL and getServiceURL to generate URLs with trailing dots, such as "my-service.my-namespace.svc.cluster.local.:3000", which makes it unambiguous to the DNS resolver, speeding up DNS resolution by avoiding unnecessary queries. Signed-off-by: Joel Takvorian <jtakvori@redhat.com>
|
@jotak: This pull request references Jira Issue OCPBUGS-77026, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jotak: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Update getProxyServiceURL and getServiceURL to generate URLs with trailing dots, such as
"my-service.my-namespace.svc.cluster.local.:3000", which makes it unambiguous to the DNS resolver, speeding up DNS resolution by avoiding unnecessary queries.