[WIP] CONSOLE-4447: Remove deprecated modal components and CSS#16126
Open
rhamilto wants to merge 5 commits intoopenshift:mainfrom
Open
[WIP] CONSOLE-4447: Remove deprecated modal components and CSS#16126rhamilto wants to merge 5 commits intoopenshift:mainfrom
rhamilto wants to merge 5 commits intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
Contributor
|
@rhamilto: This pull request references CONSOLE-4447 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Contributor
|
@rhamilto: This pull request references CONSOLE-4447 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhamilto The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
openshift-merge-robot
added
the
needs-rebase
openshift-ci
bot
added
component/shared
rhamilto
force-pushed
the
CONSOLE-4447-legacy-removal
branch
2 times, most recently
from
245f6d2 to
e145baf
Compare
openshift-merge-robot
removed
the
needs-rebase
rhamilto
force-pushed
the
CONSOLE-4447-legacy-removal
branch
from
e145baf to
29c4fdf
Compare
Member
Author
|
/retest |
rhamilto
force-pushed
the
CONSOLE-4447-legacy-removal
branch
3 times, most recently
from
aa75aed to
6c64d2b
Compare
Member
Author
|
/test e2e-gcp-console |
rhamilto
force-pushed
the
CONSOLE-4447-legacy-removal
branch
5 times, most recently
from
eca80a1 to
41c945f
Compare
openshift-merge-robot
added
the
needs-rebase
rhamilto
force-pushed
the
CONSOLE-4447-legacy-removal
branch
from
41c945f to
eabc43f
Compare
openshift-merge-robot
removed
the
needs-rebase
Contributor
|
performed some regression testing about several impacted modals, no regression/breaking changes found /verified by @yapei |
openshift-ci-robot
added
the
verified
Contributor
|
@yapei: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
Not sure why it is failing, the cypress selector looks good |
Contributor
|
/retest-required |
rhamilto
force-pushed
the
CONSOLE-4447-legacy-removal
branch
from
eabc43f to
5f44c59
Compare
openshift-ci-robot
removed
the
verified
Migrates DeleteHPAModal, ConsolePluginModal, and DeleteResourceModal from deprecated factory modal components to modern PatternFly v6 Modal. Changes: - Replace ModalWrapper with Modal component with state management - Replace ModalTitle with ModalHeader - Replace ModalSubmitFooter with ModalFooterWithAlerts - Replace HTML form with PatternFly Form component - Use modern Button components with consistent loading/disabled states - Maintain Formik integration in DeleteResourceModal Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…ndency Remove all deprecated modal components (ModalWrapper, ModalTitle, ModalBody, ModalFooter, ModalSubmitFooter) from the modal factory as they have been fully migrated to PatternFly v6 Modal components. Changes: - Remove deprecated modal component implementations from modal.tsx - Keep only ModalComponentProps type for backward compatibility - Remove react-modal package dependency from package.json - Remove react-modal initialization code from app.tsx All modals have been migrated to use PatternFly v6 Modal components with the useOverlay hook pattern. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
openshift-merge-robot
added
the
needs-rebase
…factory/modal.tsx Relocates the ModalComponentProps type definition to a proper shared location and removes the deprecated factory/modal.tsx file entirely. This completes the removal of all deprecated modal components. Changes: - Create new file packages/console-shared/src/types/modal.ts with ModalComponentProps type - Update all imports across the codebase to use @console/shared/src/types/modal - Remove public/components/factory/modal.tsx - Remove modal export from public/components/factory/index.tsx Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Remove CSS classes that were orphaned after migrating modals to PatternFly v6. This commit: - Deletes _modals.scss and _modal-wrapper.scss files - Removes className="co-modal-table" from Table components in modals - Updates style imports and references Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
rhamilto
force-pushed
the
CONSOLE-4447-legacy-removal
branch
from
5f44c59 to
c4c4f60
Compare
openshift-merge-robot
removed
the
needs-rebase
Contributor
|
@rhamilto: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Member
Author
Should be fixed. Note this change is in #16079, but is also included here since this PR is dependent on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the migration to PatternFly v6 modals by removing deprecated modal components and cleaning up legacy CSS:
ModalTitle,ModalSubmitFooter,ModalWrapper) from@console/internal/components/factory/modalModalComponentPropstype to@console/shared/src/types/modaland updated 32 importspublic/components/modals/_modals.scssand all orphaned CSS classesreact-modaldependencyNote: this PR should merge last for this story.
Breaking Changes
For dynamic plugin developers:
.co-overlay,.modal-footer,.modal-paragraph,.modal-header,.modal-body,.modal-body-border,.modal-body-content,.modal-content,.modal-dialog,.co-modal-table,.modal__inline-resource-link.pf-v6-c-modal-box__body) or data-test attributesTest Plan
Related PRs
Part of the CONSOLE-4447 modal migration series:
🤖 Generated with Claude Code