OCPBUGS-78390: Reset pagination page when changing namespace

[rhamilto]

Summary

Fixes OCPBUGS-78390 - When switching namespaces/projects via the project picker, the page query parameter was persisting from the previous namespace, causing the table to display incorrectly (e.g., showing "51-3 of 3" with no data rows).

After

Screen.Recording.2026-03-12.at.2.43.28.PM.mov

Changes

This fix addresses the issue at two layers:

1. Navigation layer (ui.ts) - formatNamespaceRoute() removes the page query parameter when building the new URL during namespace changes, while preserving perPage as a user preference.

2. Component layer (useConsoleDataViewData.tsx) - Tracks namespace changes and resets pagination to page 1 when the namespace changes, similar to how it already resets when filters change.

Testing

• ✅ All existing tests pass
• ✅ Added 5 new test cases to verify pagination query parameter handling
• ✅ Manually tested: Navigate to /k8s/all-namespaces/core~v1~Pod?page=2&perPage=50, switch to a different namespace → pagination resets to page 1, perPage is preserved
• ✅ Manually tested: Switching namespaces when on page 1 preserves all query params

Test Plan

1. Navigate to /k8s/all-namespaces/core~v1~Pod?page=2&perPage=50
2. Use the project picker to switch to the openshift-apiserver namespace
3. Verify the table displays correctly with data from page 1
4. Verify the URL shows ?perPage=50 (page param removed, perPage preserved)
5. Verify pagination controls show "1-X of Y" correctly

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Fixed pagination reset behavior when switching between namespaces. The page now correctly returns to the first page while maintaining other active filters and display settings for consistent navigation.

[openshift-ci-robot]

@rhamilto: This pull request references Jira Issue OCPBUGS-78390, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Fixes OCPBUGS-78390 - When switching namespaces/projects via the project picker, the page query parameter was persisting from the previous namespace, causing the table to display incorrectly (e.g., showing "51-3 of 3" with no data rows).

Changes

This fix addresses the issue at two layers:

1. Navigation layer (ui.ts) - formatNamespaceRoute() removes the page query parameter when building the new URL during namespace changes, while preserving perPage as a user preference.

2. Component layer (useConsoleDataViewData.tsx) - Tracks namespace changes and resets pagination to page 1 when the namespace changes, similar to how it already resets when filters change.

Testing

• ✅ All existing tests pass
• ✅ Added 5 new test cases to verify pagination query parameter handling
• ✅ Manually tested: Navigate to /k8s/all-namespaces/core~v1~Pod?page=2&perPage=50, switch to a different namespace → pagination resets to page 1, perPage is preserved
• ✅ Manually tested: Switching namespaces when on page 1 preserves all query params

Test Plan

1. Navigate to /k8s/all-namespaces/core~v1~Pod?page=2&perPage=50
2. Use the project picker to switch to the openshift-apiserver namespace
3. Verify the table displays correctly with data from page 1
4. Verify the URL shows ?perPage=50 (page param removed, perPage preserved)
5. Verify pagination controls show "1-X of Y" correctly

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rhamilto]

/assign @vikram-raj
since he's been looking at this code recently.

[coderabbitai]

📝 Walkthrough

Walkthrough

This change implements pagination reset logic when the active namespace changes within the data view. The implementation tracks namespace changes via a ref comparison, extends the pagination reset condition to trigger on namespace changes, and modifies the formatNamespaceRoute function to remove the page parameter from URL search params when the namespace changes while preserving other search parameters and the location hash. Supporting tests verify the page parameter removal on namespace transitions, preservation of other query parameters, and handling of edge cases like empty query strings.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically summarizes the main change: resetting pagination when switching namespaces, which is the core fix for OCPBUGS-78390.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can use oxc to improve the quality of JavaScript and TypeScript code reviews.

Add a configuration file to your project to customize how CodeRabbit runs oxc.

[rhamilto]

/cherry-pick release-4.21

[openshift-cherrypick-robot]

@rhamilto: once the present PR merges, I will cherry-pick it on top of release-4.21 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[rhamilto]

/jira refresh

[openshift-ci-robot]

@rhamilto: This pull request references Jira Issue OCPBUGS-78390, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rhamilto]

/retest

[rhamilto]

/retest

[rhamilto]

/retest

[openshift-ci]

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[vikram-raj]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [rhamilto,vikram-raj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhamilto]

/assign @yapei

[yapei]

@yanpzhan will help verify