[wip] CONSOLE-5015: Refactor pinned nav to react-drag-drop#16146
[wip] CONSOLE-5015: Refactor pinned nav to react-drag-drop#16146logonoff wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
@logonoff: This pull request references CONSOLE-5015 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label px-approved |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
96ee051 to
bd4980b
Compare
📝 WalkthroughWalkthroughThis pull request refactors the pinned resources drag-and-drop functionality in the perspective navigation component. The 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
| "@patternfly/react-core": "~6.4.0", | ||
| "@patternfly/react-data-view": "~6.3.0", | ||
| "@patternfly/react-drag-drop": "~6.4.0", | ||
| "@patternfly/react-drag-drop": "~6.5.0-prerelease.38", |
There was a problem hiding this comment.
Needed to pick up patternfly/patternfly-react#12217 / patternfly/patternfly-react#12240. no impact on plugins as this is not a shared module and does not provide CSS
|
@logonoff: This pull request references CONSOLE-5015 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@frontend/packages/console-app/src/components/nav/PinnedResource.tsx`:
- Line 50: The component PinnedResource uses the optional prop navResources
directly with .filter(), which can throw if navResources is undefined; update
the PinnedResource component to guard navResources before calling .filter() by
either defaulting navResources to an empty array in the function signature or
using a safe access (e.g., (navResources || []).filter(...) or
navResources?.filter(...) with a fallback) so all uses in the component
(including where navResources is iterated/filtered) cannot cause a runtime
crash.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ded4e51a-762c-4927-97f0-f5de30d0c000
⛔ Files ignored due to path filters (1)
frontend/yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (5)
frontend/package.jsonfrontend/packages/console-app/src/components/nav/PerspectiveNav.scssfrontend/packages/console-app/src/components/nav/PerspectiveNav.tsxfrontend/packages/console-app/src/components/nav/PinnedResource.tsxfrontend/packages/console-app/src/components/nav/__tests__/PerspectiveNav.spec.tsx
1efbbaf to
349557a
Compare
349557a to
a0b30ff
Compare
|
@logonoff: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
After
Screencast.From.2026-03-13.16-04-45.mp4
Summary by CodeRabbit
New Features
Style