dispatcher: parse FROM --after=<stage> #316
Conversation
|
CI failure here I think is unrelated. Looks like a Docker API version mismatch. FWIW, I got this to work locally by setting |
|
This either needs to implement |
Updated! I went with just erroring out for now as mentioned in the commit message:
|
|
@jlebon seems you have a build failure here.... |
One of them was failing in the conforming tests with what I mentioned in #316 (comment). The other one didn't seem to have any obvious error. It looks truncated? I repushed to force a retrigger. Let's see what happens... |
|
It's persistent. I think CI just needs some love. Looks like that's happening in #317. :) |
|
Rebased for CI! |
|
Looks to be passing! Are you planning to add a test or two? I could have sworn you had a test when I reviewed the last time.... |
|
I added a test in containers/buildah#6654, but I can add one here too if desired! |
|
@jlebon Yes, please add a test here too. |
Done! Did something in line with what's done for the |
|
LGTM, thanks! |
|
LGTM |
This allows defining a dependency on another stage for cases when buildah otherwise wouldn't be able to automatically infer it. See containers/buildah#6621 for details. The corresponding buildah patch making use of this will have more info. For now, makes this an explicitly error if used with the dockerclient. I don't see the use case for it there currently given that this flag is to help leverage a buildah-specific feature. Assisted-by: Claude Opus 4.5 Signed-off-by: Jonathan Lebon <jonathan@jlebon.com>
|
Sorry, I had screwed up the squashing here when I added tests and had the wrong commit message. Now fixed! Commit content itself didn't change. |
|
@jlebon: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I think this needs actual |
|
/approved |
|
LGTM |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlebon, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
3 participants
This allows defining a dependency on another stage for cases when buildah otherwise wouldn't be able to automatically infer it. See containers/buildah#6621 for details.
The corresponding buildah patch making use of this will have more info.
For now, makes this an explicitly error if used with the dockerclient. I don't see the use case for it there currently given that this flag is to help leverage a buildah-specific feature.
Assisted-by: Claude Opus 4.5