Skip to content

Tests: Add check to ensure page has loaded before continuing#1561

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
kyoto:tests-wait-for-page-load
Mar 6, 2026
Merged

Tests: Add check to ensure page has loaded before continuing#1561
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
kyoto:tests-wait-for-page-load

Conversation

@kyoto
Copy link
Member

@kyoto kyoto commented Feb 27, 2026

No description provided.

@kyoto kyoto added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2026
@openshift-ci openshift-ci bot requested review from JoaoFula and xrajesh February 27, 2026 05:37
@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyoto kyoto force-pushed the tests-wait-for-page-load branch from 2271e21 to 288b7b0 Compare March 6, 2026 01:30
@JoaoFula
Copy link
Contributor

JoaoFula commented Mar 6, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 4f22808 into openshift:main Mar 6, 2026
4 checks passed
@kyoto kyoto deleted the tests-wait-for-page-load branch March 6, 2026 07:30
@kyoto
Copy link
Member Author

kyoto commented Mar 6, 2026

/cherry-pick pattern-fly-5

@openshift-cherrypick-robot

@kyoto: #1561 failed to apply on top of branch "pattern-fly-5":

Applying: Tests: Add check to ensure page has loaded before continuing
Using index info to reconstruct a base tree...
M	tests/tests/lightspeed-install.cy.ts
Falling back to patching base and 3-way merge...
Auto-merging tests/tests/lightspeed-install.cy.ts
CONFLICT (content): Merge conflict in tests/tests/lightspeed-install.cy.ts
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Tests: Add check to ensure page has loaded before continuing

Details

In response to this:

/cherry-pick pattern-fly-5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants