Skip to content

Conversation

@agullon
Copy link
Contributor

@agullon agullon commented Dec 5, 2025

This PR adds the capability to test Z-stream upgrades (e.g., 4.22.3 -> 4.22.7) in addition to the existing Y-stream upgrade tests (e.g., 4.21 -> 4.22).

Changes include:

  • Add 2 new Release Testing bootc scenarios to exercise previous Z upgrade path
  • Add bootc containerfile and scenario files for previous Z upgrade testing
  • Add PREV_ZSTREAM version variables for tracking theprevious z-stream of the current minor release
  • Rename variables from confusing Y0/Z1/Y1/Y2 pattern to clearer naming:
    • LATEST_ZSTREAM_VERSION: Latest z-stream of current minor
    • PREV_ZSTREAM_VERSION: Previous z-stream of current minor
    • YMINUS1_VERSION: Latest z-stream of Y-1 minor
    • YMINUS2_VERSION: Latest z-stream of Y-2 minor
  • Add documentation comments explaining the version naming convention

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 5, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 5, 2025

@agullon: This pull request references USHIFT-6073 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from eslutsky and jogeo December 5, 2025 10:01
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2025
@agullon
Copy link
Contributor Author

agullon commented Dec 5, 2025

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 9, 2025

@agullon: This pull request references USHIFT-6073 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

Details

In response to this:

  • Add 2 new Release Testing scenarios to exercise Z-1 upgrade path.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 9, 2025

@agullon: This pull request references USHIFT-6073 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

Details

In response to this:

  • Add 2 new Release Testing bootc scenarios to exercise Z-1 upgrade path
  • Changes brew-rpms sub dirs from X.Y-(zstream|ec|rc|nightly) format to X.Y.Z-(ec|rc|nightly) to support Z-1 versions
    • find_package option added to manage_brew_rpms.sh to support it

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 9, 2025

@agullon: This pull request references USHIFT-6073 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

Details

In response to this:

  • Add 2 new Release Testing bootc scenarios to exercise Z-1 upgrade path
  • Changes brew-rpms sub dirs from X.Y-(zstream|ec|rc|nightly) format to X.Y.Z-(ec|rc|nightly) to support Z-1 versions
    • find_package option added to manage_brew_rpms.sh to support it

⚠️ PR openshift/release#72367 must be merged at the same time.

  • also backport this to release-4.20 and release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 10, 2025

@agullon: This pull request references USHIFT-6073 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

Details

In response to this:

  • Add 2 new Release Testing bootc scenarios to exercise Z-1 upgrade path
  • Changes brew-rpms sub dirs from X.Y-(zstream|ec|rc|nightly) format to X.Y.Z{-(ec|rc|nightly)} to support Z-1 versions
    • find_package option added to manage_brew_rpms.sh to support it

⚠️ PR openshift/release#72367 must be merged at the same time.

  • also backport this to release-4.20 and release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agullon
Copy link
Contributor Author

agullon commented Dec 10, 2025

/test e2e-aws-tests-bootc-release-arm e2e-aws-tests-bootc-release

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 15, 2025

@agullon: This pull request references USHIFT-6073 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

  • Add 2 new Release Testing bootc scenarios to exercise Z-1 upgrade path
  • Changes brew-rpms sub dirs from X.Y-(zstream|ec|rc|nightly) format to X.Y.Z{-(ec|rc|nightly)} to support Z-1 versions
    • find_package option added to manage_brew_rpms.sh to support it

⚠️ PR openshift/release#72367 must be merged at the same time.

  • also backport this to release-4.21, release-4.20 and release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 15, 2025

@agullon: This pull request references USHIFT-6073 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

  • Add 2 new Release Testing bootc scenarios to exercise Z-1 upgrade path
  • Changes brew-rpms sub dirs from X.Y-(zstream|ec|rc|nightly) format to X.Y.Z{-(ec|rc|nightly)} to support Z-1 versions
    • find_package option added to manage_brew_rpms.sh to support it

⚠️ PR openshift/release#72367 must be merged first to be able to download Z-1 brew RPMs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Contributor

/hold

I would like us to try implementing the same without adding extra options / dimensions to the manage_brew_rpms.sh script (i.e. 0 and 1 flags).
One idea is to always download more than one latest versions, for example the last two. This way, previous version should be handy in the cache if required.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 17, 2025

@agullon: This pull request references USHIFT-6073 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

  • Add 2 new Release Testing bootc scenarios to exercise Z-1 upgrade path
  • Changes brew-rpms sub dirs from X.Y-(zstream|ec|rc|nightly) format to X.Y.Z{-(ec|rc|nightly)} to support Z-1 versions
  • manage_brew_rpms.sh download 4.${X} ${OUTPUT_DIR} stream now downloads internally 4 different versions. Example for X=19:
    • Y0_VERSION=4.19.7
    • Z1_VERSION=4.19.0
    • Y1_VERSION=4.18.26
    • Y2_VERSION=4.17.44

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agullon
Copy link
Contributor Author

agullon commented Dec 18, 2025

/retest

2 similar comments
@agullon
Copy link
Contributor Author

agullon commented Dec 18, 2025

/retest

@agullon
Copy link
Contributor Author

agullon commented Dec 18, 2025

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2025

@agullon: This pull request references USHIFT-6073 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

  • Add 2 new Release Testing bootc scenarios to exercise Z-1 upgrade path
  • Changes brew-rpms sub dirs from X.Y-(zstream|ec|rc|nightly) format to X.Y.Z{-(ec|rc|nightly)} to support Z-1 versions
  • manage_brew_rpms.sh download 4.${X} ${OUTPUT_DIR} zstream now downloads internally 4 different versions: current, Z-1, Y-2 and Y-1. Example for X=19:
    • Y0_VERSION=4.19.7
    • Z1_VERSION=4.19.0
    • Y1_VERSION=4.18.26
    • Y2_VERSION=4.17.44

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2025

@agullon: This pull request references USHIFT-6073 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

  • Add 2 new Release Testing bootc scenarios to exercise Z-1 upgrade path
  • Changes brew-rpms sub dirs from X.Y-(zstream|ec|rc|nightly) format to X.Y.Z{-(ec|rc|nightly)} to support Z-1 versions
  • manage_brew_rpms.sh download 4.${X} ${OUTPUT_DIR} zstream now downloads internally 4 different versions: current, Z-1, Y-2 and Y-1.
    • Example for X=19:
      • Y0_VERSION=4.19.7
      • Z1_VERSION=4.19.0
      • Y1_VERSION=4.18.26
      • Y2_VERSION=4.17.44

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agullon
Copy link
Contributor Author

agullon commented Dec 19, 2025

/hold

I would like us to try implementing the same without adding extra options / dimensions to the manage_brew_rpms.sh script (i.e. 0 and 1 flags).
One idea is to always download more than one latest versions, for example the last two. This way, previous version should be handy in the cache if required.

@ggiguash can you please review this PR again please? I modified the implementation with your suggestion. See PR description.

Important, CI jobs are using custom S3 bucket to not mess up the cache: AWS_BUCKET_NAME="microshift-build-ushift-6073-cache-us-west-2"

@agullon
Copy link
Contributor Author

agullon commented Dec 24, 2025

/test e2e-aws-tests-bootc-release e2e-aws-tests-release e2e-aws-tests-bootc-release-arm e2e-aws-tests-release-arm

@agullon
Copy link
Contributor Author

agullon commented Dec 24, 2025

/test e2e-aws-tests-bootc-release

@agullon
Copy link
Contributor Author

agullon commented Jan 21, 2026

/retest

1 similar comment
@agullon
Copy link
Contributor Author

agullon commented Jan 21, 2026

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 30, 2026

@agullon: This pull request references USHIFT-6073 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR adds the capability to test Z-stream upgrades (e.g., 4.22.3 -> 4.22.7) in addition to the existing Y-stream upgrade tests (e.g., 4.21 -> 4.22).

Changes include:

  • Add 2 new Release Testing bootc scenarios to exercise previous Z upgrade path
  • Add bootc containerfile and scenario files for previous Z upgrade testing
  • Add PREV_ZSTREAM version variables for tracking theprevious z-stream of the current minor release
  • Rename variables from confusing Y0/Z1/Y1/Y2 pattern to clearer naming:
  • LATEST_ZSTREAM_VERSION: Latest z-stream of current minor
  • PREV_ZSTREAM_VERSION: Previous z-stream of current minor
  • YMINUS1_VERSION: Latest z-stream of Y-1 minor
  • YMINUS2_VERSION: Latest z-stream of Y-2 minor
  • Add documentation comments explaining the version naming convention

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agullon
Copy link
Contributor Author

agullon commented Jan 30, 2026

/test e2e-aws-tests-cache
/test e2e-aws-tests-cache-arm

@agullon
Copy link
Contributor Author

agullon commented Jan 30, 2026

/test e2e-aws-tests-cache
/test e2e-aws-tests-cache-arm

This PR adds the capability to test Z-stream upgrades (e.g., 4.22.0 -> 4.22.7)
in addition to the existing Y-stream upgrade tests (e.g., 4.21 -> 4.22).

Changes include:
- Add PREV_ZSTREAM version variables for tracking the first/previous z-stream
  of the current minor release
- Add bootc containerfile and scenario files for Z-1 upgrade testing
- Rename variables from confusing Y0/Z1/Y1/Y2 pattern to clearer naming:
  - LATEST_ZSTREAM_VERSION: Latest z-stream of current minor
  - PREV_ZSTREAM_VERSION: Previous z-stream of current minor (Z-1 upgrade source)
  - YMINUS1_VERSION: Latest z-stream of Y-1 minor
  - YMINUS2_VERSION: Latest z-stream of Y-2 minor
- Add documentation comments explaining the version naming convention

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@agullon
Copy link
Contributor Author

agullon commented Jan 30, 2026

/test e2e-aws-tests-cache
/test e2e-aws-tests-cache-arm

@agullon agullon changed the title USHIFT-6073: Add upgrade path on releases scenarios: from Z-1 USHIFT-6073: Add "from previous Z" upgrade path on releases scenarios Jan 30, 2026
rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@agullon
Copy link
Contributor Author

agullon commented Jan 30, 2026

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 30, 2026

@agullon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

source "${SCRIPTDIR}/common.sh"

AWS_BUCKET_NAME="${AWS_BUCKET_NAME:-microshift-build-cache}"
AWS_BUCKET_NAME="microshift-build-ushift-6073-cache-us-west-2"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line has been added only for testing purposes. It must be removed before merging.

@agullon
Copy link
Contributor Author

agullon commented Jan 30, 2026

@ggiguash I've updated the variable names for better clarity, please review it again. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants