Skip to content

USHIFT-6984: Skip RPM scenario tests when no brew RPMs are available #6707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
copejon wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −0
Draft

USHIFT-6984: Skip RPM scenario tests when no brew RPMs are available #6707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/scenarios/releases/el98@rpm-standard1.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ scenario_remove_vms() {
}

scenario_run_tests() {
if [[ -z "${BREW_LREL_RELEASE_VERSION}" ]]; then
echo "WARNING: No brew RPMs available for ${MAJOR_VERSION}.${MINOR_VERSION}, skipping RPM tests"
return 0
fi
Comment on lines +66 to +69
Copy link
Copy Markdown
Contributor

@agullon agullon May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copejon I'll extract this a function into scenario.sh script to follow the same approach as: exit_if_image_not_found() and exit_if_commit_not_found().

Also, I'll add this check in the 3 steps on the scenario: create VM, run tests and remove VM.


local -r reponame=$(basename "${BREW_REPO}")
local -r repo_url="${WEB_SERVER_URL}/rpm-repos/${reponame}"

Expand Down
5 changes: 5 additions & 0 deletions test/scenarios/releases/el98@rpm-standard2.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,11 @@ scenario_remove_vms() {
}

scenario_run_tests() {
if [[ -z "${BREW_LREL_RELEASE_VERSION}" ]]; then
echo "WARNING: No brew RPMs available for ${MAJOR_VERSION}.${MINOR_VERSION}, skipping RPM tests"
return 0
fi

local -r reponame=$(basename "${BREW_REPO}")
local -r repo_url="${WEB_SERVER_URL}/rpm-repos/${reponame}"

Expand Down
5 changes: 5 additions & 0 deletions test/scenarios/releases/el98@rpm-upgrade.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,11 @@ scenario_remove_vms() {
}

scenario_run_tests() {
if [[ -z "${BREW_LREL_RELEASE_VERSION}" ]]; then
echo "WARNING: No brew RPMs available for ${MAJOR_VERSION}.${MINOR_VERSION}, skipping RPM tests"
return 0
fi

local -r reponame=$(basename "${BREW_REPO}")
local -r repo_url="${WEB_SERVER_URL}/rpm-repos/${reponame}"

Expand Down