Skip to content

OCPBUGS-77868: Clean up cruft in /var/cache/dnf#360

Merged
sdodson merged 1 commit intoopenshift:mainfrom
sdodson:OCPBUGS-77868
Mar 5, 2026
Merged

OCPBUGS-77868: Clean up cruft in /var/cache/dnf#360
sdodson merged 1 commit intoopenshift:mainfrom
sdodson:OCPBUGS-77868

Conversation

@sdodson
Copy link
Member

@sdodson sdodson commented Mar 5, 2026

Summary by CodeRabbit

  • Chores
    • Optimized Docker image builds with additional cache cleanup steps to reduce image size and improve build efficiency.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 5, 2026
@openshift-ci-robot
Copy link

@sdodson: This pull request references Jira Issue OCPBUGS-77868, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @joepvd

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from joepvd March 5, 2026 15:18
@coderabbitai
Copy link

coderabbitai bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7f05f9e8-7d7e-4638-8f14-cbc0c766042f

📥 Commits

Reviewing files that changed from the base of the PR and between 7eb7432 and 2b9f65b.

📒 Files selected for processing (2)
  • Dockerfile
  • Dockerfile.art

Walkthrough

Two Dockerfile configurations are updated to add an extra cache cleanup step. In both files, rm -rf /var/cache/dnf/* is appended to existing package cache cleaning commands to further reduce image size after the initial clean operation.

Changes

Cohort / File(s) Summary
Cache Cleanup Enhancement
Dockerfile, Dockerfile.art
Added rm -rf /var/cache/dnf/* command to purge additional package cache in the final image stage, following existing cache clean operations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically summarizes the main change: adding cleanup of /var/cache/dnf cache in Dockerfile and Dockerfile.art to reduce image size.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed This custom check is not applicable to the provided pull request. The check is designed to validate test naming practices in test files, but this PR only modifies Dockerfile and Dockerfile.art files, which are infrastructure configuration files that do not contain test declarations.
Test Structure And Quality ✅ Passed PR contains only Dockerfile modifications with no test code changes, making the test quality check criteria inapplicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@sdodson
Copy link
Member Author

sdodson commented Mar 5, 2026

/label lgtm approved

@openshift-ci openshift-ci bot requested review from gouyang and metalice March 5, 2026 15:21
@openshift-ci
Copy link

openshift-ci bot commented Mar 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sdodson
Once this PR has been reviewed and has the lgtm label, please assign rszwajko for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson
Copy link
Member Author

sdodson commented Mar 5, 2026

/label approved

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2026
@openshift-ci
Copy link

openshift-ci bot commented Mar 5, 2026

@sdodson: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sdodson sdodson merged commit 972e3b2 into openshift:main Mar 5, 2026
5 of 6 checks passed
@openshift-ci-robot
Copy link

@sdodson: Jira Issue OCPBUGS-77868: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-77868 has not been moved to the MODIFIED state.

Details

In response to this:

Summary by CodeRabbit

  • Chores
  • Optimized Docker image builds with additional cache cleanup steps to reduce image size and improve build efficiency.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sdodson
Copy link
Member Author

sdodson commented Mar 5, 2026

/cherry-pick release-4.21 release-4.20 release-4.19 release-4.18

@openshift-cherrypick-robot

@sdodson: #360 failed to apply on top of branch "release-4.21":

Applying: OCPBUGS-77868: Clean up cruft in /var/cache/dnf
Using index info to reconstruct a base tree...
M	Dockerfile
M	Dockerfile.art
Falling back to patching base and 3-way merge...
Auto-merging Dockerfile.art
CONFLICT (content): Merge conflict in Dockerfile.art
Auto-merging Dockerfile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-77868: Clean up cruft in /var/cache/dnf

Details

In response to this:

/cherry-pick release-4.21 release-4.20 release-4.19 release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sdodson
Copy link
Member Author

sdodson commented Mar 5, 2026

/jira backport release-4.21

@openshift-ci-robot
Copy link

@sdodson: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.21

Details

In response to this:

/jira backport release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@openshift-ci-robot: #360 failed to apply on top of branch "release-4.21":

Applying: OCPBUGS-77868: Clean up cruft in /var/cache/dnf
Using index info to reconstruct a base tree...
M	Dockerfile
M	Dockerfile.art
Falling back to patching base and 3-way merge...
Auto-merging Dockerfile.art
CONFLICT (content): Merge conflict in Dockerfile.art
Auto-merging Dockerfile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-77868: Clean up cruft in /var/cache/dnf

Details

In response to this:

@sdodson: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.21

In response to this:

/jira backport release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.22.0-0.nightly-2026-03-06-163638

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.22.0-0.nightly-2026-03-07-091925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants