CNV#57055: RN 4.20 - Deprecate syntax - new virtctl port-forward / ssh / scp syntax #104093
Conversation
openshift-ci
bot
added
the
size/XS
danielclowers
changed the title
|
🤖 Wed Dec 17 19:16:19 - Prow CI generated the docs preview: |
|
@danielclowers: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
danielclowers
changed the title
|
lgtm |
|
I may be wrong, but IIUC the original PR of this: kubevirt/kubevirt#13939 |
| == Bug fixes | ||
|
|
||
| // CNV-71711 | ||
| * The `virtctl ssh` command now requires specifying an explicit resource type when targeting a virtual machine. You must prefix the target name with `vmi/` or `vm/`. Scripts that relied on the previous syntax without a resource type might fail after upgrading. (link:https://issues.redhat.com/browse/CNV-71711[*CNV-71711*]) |
There was a problem hiding this comment.
Should this be under the "Deprecated features" section instead of "Bug fixes"?
| == Bug fixes | ||
|
|
||
| // CNV-71711 | ||
| * The `virtctl ssh` command now requires specifying an explicit resource type when targeting a virtual machine. You must prefix the target name with `vmi/` or `vm/`. Scripts that relied on the previous syntax without a resource type might fail after upgrading. (link:https://issues.redhat.com/browse/CNV-71711[*CNV-71711*]) |
There was a problem hiding this comment.
I would suggest rewording this to say something like the virtctl ssh type/name[.namespace] command syntax is now deprecated. Instead, use the virtctl ssh type/name[/namespace] syntax to access a VM via SSH.
It might be helpful to describe what the type, name, and namespace attributes specify in this context.
5 participants
Version(s):
4.20
Issue:
https://issues.redhat.com/browse/CNV-57055
Link to docs preview:
https://104093--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/release_notes/virt-4-20-release-notes.html#virt-4-20-bug-fixes_virt-4-20-release-notes
QE review:
Additional information: