Skip to content

OSDOCS-13260-4.18# Add docs for enabling token-based auth on existing aws cluster and include OSDOCS-16789 bug fix.#104291

Merged
snarayan-redhat merged 1 commit intoopenshift:enterprise-4.18from
sslocket:OSDOCS-13260-4.18
Jan 30, 2026
Merged

OSDOCS-13260-4.18# Add docs for enabling token-based auth on existing aws cluster and include OSDOCS-16789 bug fix.#104291
snarayan-redhat merged 1 commit intoopenshift:enterprise-4.18from
sslocket:OSDOCS-13260-4.18

Conversation

@sslocket
Copy link
Copy Markdown
Contributor

@sslocket sslocket commented Dec 23, 2025

@openshift-ci openshift-ci Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 23, 2025
@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented Dec 23, 2025

@jstuever
Copy link
Copy Markdown

lgtm
The code looks like a clean backport. I'm relying on QE to validate that it actually works.

@jianping-shu
Copy link
Copy Markdown

lgtm

@sslocket
Copy link
Copy Markdown
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci Bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 29, 2026
@snarayan-redhat snarayan-redhat added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 29, 2026
Copy link
Copy Markdown
Contributor

@snarayan-redhat snarayan-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit. Otherwise lgtm.


.Procedure

. Create an output directory for `ccoctl` generated manifests.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. Create an output directory for `ccoctl` generated manifests.
. Create an output directory for `ccoctl` generated manifests by running the following command:

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 30, 2026

@sslocket: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@snarayan-redhat snarayan-redhat added ok-to-merge branch/enterprise-4.18 and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR labels Jan 30, 2026
@snarayan-redhat snarayan-redhat added this to the Continuous Release milestone Jan 30, 2026
@snarayan-redhat snarayan-redhat merged commit cfd55e2 into openshift:enterprise-4.18 Jan 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.18 ok-to-merge size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants