Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jacobsee The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
d07f389 to
b8a24bc
Compare
3d079e3 to
31ce883
Compare
|
/testwith openshift/kubernetes#2523 |
|
/test lint |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughBump Go and CI/base images to 1.25, update many module versions and replace directives in go.mod, tighten golangci-lint config, small API-alignment fixes in tests/util, adjust allowed test images, and remove injected-image-generation logic from the image mirror command. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Around line 420-451: The go.mod contains replace directives redirecting many
k8s.io and OpenShift modules to personal forks (e.g. "k8s.io/api =>
github.com/jacobsee/kubernetes..." and similar replacements); remove all replace
directives that point to github.com/jacobsee/* (and any other personal forks) so
dependencies resolve to upstream modules/versions instead, then run go mod tidy
(and go mod vendor or CI dependency verification) to ensure the module graph is
clean; specifically remove the replace blocks referencing k8s.io/* and the
OpenShift modules so the project uses the canonical upstream modules.
ℹ️ Review info
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
⛔ Files ignored due to path filters (291)
go.sumis excluded by!**/*.sumtest/extended/util/image/zz_generated.txtis excluded by!**/zz_generated*vendor/cyphar.com/go-pathrs/.golangci.ymlis excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/COPYINGis excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/doc.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/handle_linux.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/internal/fdutils/fd_linux.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/internal/libpathrs/error_unix.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/internal/libpathrs/libpathrs_linux.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/procfs/procfs_linux.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/root_linux.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/utils_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/.golangci.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/LICENSE.txtis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/Makefileis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/SECURITY.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/collection.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/constraints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/version.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/containerd/errdefs/pkg/errhttp/http.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/containerd/ttrpc/metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/containerd/ttrpc/server.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/containerd/typeurl/v2/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/containerd/typeurl/v2/types_gogo.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/.golangci.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/COPYING.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/LICENSE.BSDis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/LICENSE.MPL-2.0is excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/VERSIONis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/codecov.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/gocompat_generics_go121.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/gocompat_generics_unsupported.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/internal/consts/consts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/join.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/open_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/openat2_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/openat_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/assert/assert.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/errors_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/fd/at_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/fd/fd.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/fd/fd_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/fd/mount_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/fd/openat2_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/gocompat_errors_go120.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/gocompat_errors_unsupported.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/gocompat_generics_go121.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/gocompat_generics_unsupported.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gopathrs/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gopathrs/lookup_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gopathrs/mkdir_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gopathrs/open_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gopathrs/openat2_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/kernelversion/kernel_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/linux/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/linux/mount_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/linux/openat2_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/procfs/procfs_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/procfs/procfs_lookup_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/mkdir.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/mkdir_libpathrs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/mkdir_purego.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/open.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/open_libpathrs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/open_purego.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/procfs/procfs_libpathrs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/procfs/procfs_purego.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/procfs_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/vfs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/AUTHORSis excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/common.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/swagger.yamlis excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/blkiodev/blkio.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/build/build.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/build/cache.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/build/disk_usage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/common/id_response.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/commit.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/config.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/container.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/container_top.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/container_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/disk_usage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/exec.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/health.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/hostconfig.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/hostconfig_unix.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/hostconfig_windows.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/network_settings.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/port.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/state.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/stats.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/top_response.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/update_response.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/waitcondition.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/events/events.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/filters/errors.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/filters/filters_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/filters/parse.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/image/disk_usage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/image/image_history.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/image/image_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/image/opts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/image/summary.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/mount/mount.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/network/endpoint.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/network/ipam.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/network/network.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/plugin.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/plugin_responses.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/registry/authconfig.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/registry/authenticate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/registry/registry.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/registry/search.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/storage/driver_data.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/strslice/strslice.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/common.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/config.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/container.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/network.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/node.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/runtime.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/runtime/gen.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/runtime/plugin.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/runtime/plugin.protois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/runtime/runtime.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/secret.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/service.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/swarm.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/task.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/system/info.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/time/timestamp.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/types_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/versions/compare.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/volume/disk_usage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/volume/options.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/volume/volume_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/build_cancel.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/build_prune.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/checkpoint.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/checkpoint_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/checkpoint_delete.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/checkpoint_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/client_interfaces.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/client_unix.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/client_windows.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/config_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/config_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/config_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/config_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/config_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_attach.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_commit.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_copy.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_diff.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_exec.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_export.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_kill.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_logs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_pause.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_prune.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_rename.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_resize.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_restart.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_start.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_stats.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_stop.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_top.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_unpause.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_wait.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/disk_usage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/distribution_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/envvars.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/errors.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/events.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/hijack.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_build.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_history.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_history_opts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_import.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_inspect_opts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_load.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_load_opts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_prune.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_pull.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_push.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_save.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_save_opts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_search.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_tag.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/info.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/interface_stable.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/login.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_connect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_disconnect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_prune.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/node_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/node_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/node_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/node_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/options.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/ping.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_disable.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_enable.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_install.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_push.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_set.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_upgrade.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/request.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/secret_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/secret_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/secret_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/secret_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/secret_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/service_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/service_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/service_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/service_logs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/service_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/service_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/swarm_get_unlock_key.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/swarm_init.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/swarm_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/swarm_join.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/swarm_leave.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/swarm_unlock.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/swarm_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/task_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/task_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/task_logs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/utils.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/version.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/volume_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/volume_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/volume_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/volume_prune.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/volume_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/volume_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/errdefs/defs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/errdefs/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/errdefs/helpers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/errdefs/http_helpers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/errdefs/is.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/internal/multierror/multierror.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/archive_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/changes_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/copy_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/diff_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/path_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/time_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/time_unsupported.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/utils.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/whiteouts_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/archive/wrap_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/homedir/homedir_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/homedir/homedir_others.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/idtools/idtools.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/idtools/idtools_unix.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/idtools/idtools_windows.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/pkg/idtools/usergroupadd_linux.gois excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (9)
.ci-operator.yaml.golangci.ymlgo.modimages/tests/Dockerfile.rhelpkg/e2eanalysis/e2e_analysis.gotest/extended/cli/basics.gotest/extended/util/compat_otp/container/docker_client.gotest/extended/util/configv1shim.gotest/extended/util/image/image.go
There was a problem hiding this comment.
🧹 Nitpick comments (1)
go.mod (1)
59-59: Document or align Ginkgo version requirement with replace directive.Line 59 declares
v2.25.1, but line 419 replaces it with the OpenShift forkv2.6.1-0.20251120221002-696928a6a0d7. If this divergence is intentional, document it inline to prevent confusion during future rebases. Otherwise, update the require statement to reflect the actual resolved version.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@go.mod` at line 59, The go.mod requires github.com/onsi/ginkgo/v2 at v2.25.1 but the module is replaced later with the OpenShift fork version v2.6.1-0.20251120221002-696928a6a0d7; either update the require line to match the resolved/replace version or add an inline comment next to the require (or above the replace) explaining why the forked OpenShift version is used to prevent confusion during rebases—locate the require entry for github.com/onsi/ginkgo/v2 and the replace directive for the OpenShift fork and make the require and replace consistent or document the intentional divergence.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@go.mod`:
- Line 59: The go.mod requires github.com/onsi/ginkgo/v2 at v2.25.1 but the
module is replaced later with the OpenShift fork version
v2.6.1-0.20251120221002-696928a6a0d7; either update the require line to match
the resolved/replace version or add an inline comment next to the require (or
above the replace) explaining why the forked OpenShift version is used to
prevent confusion during rebases—locate the require entry for
github.com/onsi/ginkgo/v2 and the replace directive for the OpenShift fork and
make the require and replace consistent or document the intentional divergence.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ef0b0a5e-bd40-4d3c-b45b-8593d0765803
⛔ Files ignored due to path filters (241)
go.sumis excluded by!**/*.sumtest/extended/util/image/zz_generated.txtis excluded by!**/zz_generated*vendor/cyphar.com/go-pathrs/.golangci.ymlis excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/COPYINGis excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/doc.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/handle_linux.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/internal/fdutils/fd_linux.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/internal/libpathrs/error_unix.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/internal/libpathrs/libpathrs_linux.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/procfs/procfs_linux.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/root_linux.gois excluded by!**/vendor/**,!vendor/**vendor/cyphar.com/go-pathrs/utils_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/.golangci.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/LICENSE.txtis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/Makefileis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/SECURITY.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/collection.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/constraints.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/Masterminds/semver/v3/version.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/containerd/errdefs/pkg/errhttp/http.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/containerd/ttrpc/metadata.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/containerd/ttrpc/server.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/containerd/typeurl/v2/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/containerd/typeurl/v2/types_gogo.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/.golangci.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/COPYING.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/LICENSE.BSDis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/LICENSE.MPL-2.0is excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/VERSIONis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/codecov.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/gocompat_generics_go121.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/gocompat_generics_unsupported.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/internal/consts/consts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/join.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/open_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/openat2_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/openat_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/assert/assert.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/errors_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/fd/at_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/fd/fd.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/fd/fd_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/fd/mount_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/fd/openat2_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/gocompat_errors_go120.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/gocompat_errors_unsupported.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/gocompat_generics_go121.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gocompat/gocompat_generics_unsupported.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gopathrs/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gopathrs/lookup_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gopathrs/mkdir_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gopathrs/open_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/gopathrs/openat2_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/kernelversion/kernel_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/linux/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/linux/mount_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/linux/openat2_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/procfs/procfs_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/internal/procfs/procfs_lookup_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/mkdir.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/mkdir_libpathrs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/mkdir_purego.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/open.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/open_libpathrs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/open_purego.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/procfs/procfs_libpathrs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/pathrs-lite/procfs/procfs_purego.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/procfs_linux.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cyphar/filepath-securejoin/vfs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/AUTHORSis excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/common.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/swagger.yamlis excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/blkiodev/blkio.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/build/build.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/build/cache.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/build/disk_usage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/common/id_response.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/commit.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/config.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/container.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/container_top.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/container_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/disk_usage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/exec.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/health.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/hostconfig.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/hostconfig_unix.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/hostconfig_windows.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/network_settings.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/port.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/state.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/stats.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/top_response.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/update_response.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/container/waitcondition.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/events/events.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/filters/errors.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/filters/filters_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/filters/parse.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/image/disk_usage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/image/image_history.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/image/image_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/image/opts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/image/summary.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/mount/mount.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/network/endpoint.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/network/ipam.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/network/network.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/plugin.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/plugin_responses.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/registry/authconfig.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/registry/authenticate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/registry/registry.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/registry/search.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/storage/driver_data.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/strslice/strslice.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/common.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/config.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/container.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/network.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/node.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/runtime.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/runtime/gen.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/runtime/plugin.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/runtime/plugin.protois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/runtime/runtime.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/secret.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/service.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/swarm.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/swarm/task.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/system/info.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/time/timestamp.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/types.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/types_deprecated.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/versions/compare.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/volume/disk_usage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/volume/options.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/api/types/volume/volume_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/build_cancel.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/build_prune.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/checkpoint.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/checkpoint_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/checkpoint_delete.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/checkpoint_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/client.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/client_interfaces.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/client_unix.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/client_windows.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/config_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/config_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/config_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/config_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/config_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_attach.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_commit.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_copy.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_diff.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_exec.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_export.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_kill.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_logs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_pause.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_prune.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_rename.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_resize.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_restart.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_start.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_stats.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_stop.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_top.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_unpause.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/container_wait.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/disk_usage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/distribution_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/envvars.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/errors.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/events.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/hijack.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_build.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_history.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_history_opts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_import.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_inspect_opts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_load.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_load_opts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_prune.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_pull.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_push.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_save.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_save_opts.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_search.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/image_tag.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/info.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/interface_stable.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/login.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_connect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_disconnect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_prune.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/network_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/node_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/node_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/node_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/node_update.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/options.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/ping.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_create.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_disable.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_enable.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_inspect.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_install.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_list.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_push.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_remove.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_set.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/plugin_upgrade.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/request.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/docker/docker/client/secret_create.gois excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (10)
.ci-operator.yaml.golangci.ymlgo.modimages/tests/Dockerfile.rhelpkg/cmd/openshift-tests/images/images_command.gopkg/e2eanalysis/e2e_analysis.gotest/extended/cli/basics.gotest/extended/util/compat_otp/container/docker_client.gotest/extended/util/configv1shim.gotest/extended/util/image/image.go
🚧 Files skipped from review as they are similar to previous changes (5)
- .golangci.yml
- test/extended/util/compat_otp/container/docker_client.go
- test/extended/cli/basics.go
- pkg/e2eanalysis/e2e_analysis.go
- test/extended/util/configv1shim.go
images/tests/Dockerfile.rhel
Outdated
There was a problem hiding this comment.
Please update the kube version here as well
| "registry.k8s.io/e2e-test-images/nginx:1.15-4": 16, | ||
|
|
||
| // used by DRA tests | ||
| "registry.k8s.io/e2e-test-images/sample-device-plugin:1.7": -1, |
There was a problem hiding this comment.
I understand you had to put this here because this image is hardcoded in manifest files upstream, like test/e2e/testing-manifests/sample-device-plugin/sample-device-plugin.yaml, and as a result, it's not returned by k8s-tests-ext. However, upstream images referenced here should be listed in o/k's manifest.go file above (and have an index).
The proper fix is to update upstream to list the image in k8s.io/kubernetes/test/utils/image/manifest.go instead of hardcoding the image in a manifest.
We can add the image here as a temporary solution, but let's add a comment referencing an upstream issue.
|
/retitle OCPSTRAT-2728: Rebase 1.35 |
|
@jacobsee: This pull request references OCPSTRAT-2728 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload 4.22 ci blocking |
|
@neisw: trigger 5 job(s) of type blocking for the ci release of OCP 4.22
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/05c0b960-1bd0-11f1-9370-67f5e4a789d2-0 |
|
/payload 4.22 nightly blocking |
|
@neisw: trigger 14 job(s) of type blocking for the nightly release of OCP 4.22
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a6787a50-1bda-11f1-9991-3cffd3eba205-0 |
|
/payload-job periodic-ci-openshift-hypershift-release-4.22-periodics-e2e-aks |
|
@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2a73e200-1bee-11f1-9bfc-d642d5375e0e-0 |
|
@jacobsee: This pull request references OCPSTRAT-2728 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jacobsee: This pull request references OCPSTRAT-2728 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload 4.22 ci blocking |
|
@jacobsee: trigger 5 job(s) of type blocking for the ci release of OCP 4.22
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d56856c0-1c37-11f1-939b-5db5dff96f30-0 trigger 14 job(s) of type blocking for the nightly release of OCP 4.22
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d56856c0-1c37-11f1-939b-5db5dff96f30-1 |
|
@jacobsee: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/payload 4.22 ci blocking |
|
@jacobsee: trigger 5 job(s) of type blocking for the ci release of OCP 4.22
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/322e8190-1cab-11f1-95a6-4c3dc851cd07-0 trigger 14 job(s) of type blocking for the nightly release of OCP 4.22
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/322e8190-1cab-11f1-95a6-4c3dc851cd07-1 |
|
Superseded by #30866 |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary by CodeRabbit
Chores
Style / Quality
Tests