Skip to content

OCPBUGS-77876:Backport: Remove duplicated graceful termination test from release-4.18#30702

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.18from
wangke19:backport-remove-graceful-test-to-release-4.18
Mar 5, 2026
Merged

OCPBUGS-77876:Backport: Remove duplicated graceful termination test from release-4.18#30702
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.18from
wangke19:backport-remove-graceful-test-to-release-4.18

Conversation

@wangke19
Copy link
Contributor

@wangke19 wangke19 commented Jan 20, 2026

Summary

Backport of #29930 to fix failing test in release-4.18 Hypershift environments.

Original Commit

Problem Fixed

The test "API LBs follow /readyz of kube-apiserver and stop sending requests before server shutdowns for external clients" is failing in Hypershift/HCP environments.

Failure symptoms:

Expected
    <string>: tail: '/var/log/kube-apiserver/audit.log' has appeared; following new file{"kind":"Event",...
to have prefix
    <string>: {"kind":"Event",

The test expects audit log lines to start with {"kind":"Event", but in Hypershift environments, the log output includes a tail: prefix from the container's log collection mechanism.

Solution

This test was removed from main because:

  1. The functionality is already covered by the auditloganalyzer test
  2. The test implementation has issues in Hypershift/HCP environments where audit logs are collected differently
  3. Removing the duplicate test eliminates the false failures

Changes

  • Removes the duplicated "external clients" graceful termination test
  • Removes unused imports (compress/gzip, io, ioutil, os, path, filepath, configv1, clihelpers)
  • 123 lines removed

Test Plan

  • Verify the test is removed in release-4.18
  • Confirm CI passes without this test
  • Verify auditloganalyzer still covers this functionality

/assign @wangke19

@openshift-ci openshift-ci bot requested review from deads2k and sjenning January 20, 2026 12:33
@wangke19 wangke19 changed the title Backport: Remove duplicated graceful termination test from release-4.18 NO-JIRA:Backport: Remove duplicated graceful termination test from release-4.18 Feb 25, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 25, 2026
@openshift-ci-robot
Copy link

@wangke19: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

Backport of commit 544ac99 to fix failing test in release-4.18 Hypershift environments.

Original Commit

  • 544ac99
  • Author: Vadim Rutkovsky vrutkovs@redhat.com
  • Message: "graceful_termination: remove duplicated test - This test is already performed by auditloganalyzer"

Problem Fixed

The test "API LBs follow /readyz of kube-apiserver and stop sending requests before server shutdowns for external clients" is failing in Hypershift/HCP environments.

Failure symptoms:

Expected
   <string>: tail: '/var/log/kube-apiserver/audit.log' has appeared; following new file{"kind":"Event",...
to have prefix
   <string>: {"kind":"Event",

The test expects audit log lines to start with {"kind":"Event", but in Hypershift environments, the log output includes a tail: prefix from the container's log collection mechanism.

Solution

This test was removed from main because:

  1. The functionality is already covered by the auditloganalyzer test
  2. The test implementation has issues in Hypershift/HCP environments where audit logs are collected differently
  3. Removing the duplicate test eliminates the false failures

Changes

  • Removes the duplicated "external clients" graceful termination test
  • Removes unused imports (compress/gzip, io, ioutil, os, path, filepath, configv1, clihelpers)
  • 123 lines removed

Test Plan

  • Verify the test is removed in release-4.18
  • Confirm CI passes without this test
  • Verify auditloganalyzer still covers this functionality

/assign @wangke19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link
Contributor Author

/test verify

This test is already performed by auditloganalyzer
@wangke19 wangke19 force-pushed the backport-remove-graceful-test-to-release-4.18 branch from fcef18f to 4e6e433 Compare February 26, 2026 06:09
@coderabbitai
Copy link

coderabbitai bot commented Feb 26, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@wangke19
Copy link
Contributor Author

/retest

@wangke19
Copy link
Contributor Author

The PR fix has been merged in another backport pr, so closing it.
/close

@openshift-ci openshift-ci bot closed this Feb 28, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2026

@wangke19: Closed this PR.

Details

In response to this:

The PR fix has been merged in another backport pr, so closing it.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wangke19
Copy link
Contributor Author

/reopen

@openshift-ci openshift-ci bot reopened this Feb 28, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2026

@wangke19: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wangke19
Copy link
Contributor Author

wangke19 commented Mar 4, 2026

Blocked by openshift/release#75500

@wangke19
Copy link
Contributor Author

wangke19 commented Mar 5, 2026

/verified by CI test

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 5, 2026
@openshift-ci-robot
Copy link

@wangke19: This PR has been marked as verified by CI test.

Details

In response to this:

/verified by CI test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@wangke19: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

Backport of #29930 to fix failing test in release-4.18 Hypershift environments.

Original Commit

  • 544ac99
  • Author: Vadim Rutkovsky vrutkovs@redhat.com
  • Message: "graceful_termination: remove duplicated test - This test is already performed by auditloganalyzer"

Problem Fixed

The test "API LBs follow /readyz of kube-apiserver and stop sending requests before server shutdowns for external clients" is failing in Hypershift/HCP environments.

Failure symptoms:

Expected
   <string>: tail: '/var/log/kube-apiserver/audit.log' has appeared; following new file{"kind":"Event",...
to have prefix
   <string>: {"kind":"Event",

The test expects audit log lines to start with {"kind":"Event", but in Hypershift environments, the log output includes a tail: prefix from the container's log collection mechanism.

Solution

This test was removed from main because:

  1. The functionality is already covered by the auditloganalyzer test
  2. The test implementation has issues in Hypershift/HCP environments where audit logs are collected differently
  3. Removing the duplicate test eliminates the false failures

Changes

  • Removes the duplicated "external clients" graceful termination test
  • Removes unused imports (compress/gzip, io, ioutil, os, path, filepath, configv1, clihelpers)
  • 123 lines removed

Test Plan

  • Verify the test is removed in release-4.18
  • Confirm CI passes without this test
  • Verify auditloganalyzer still covers this functionality

/assign @wangke19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dgoodwin
Copy link
Contributor

dgoodwin commented Mar 5, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, wangke19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2026
@wangke19 wangke19 changed the title NO-JIRA:Backport: Remove duplicated graceful termination test from release-4.18 OCPQE-31732:Backport: Remove duplicated graceful termination test from release-4.18 Mar 5, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2026

@wangke19: This pull request references OCPQE-31732 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.z" version, but no target version was set.

Details

In response to this:

Summary

Backport of #29930 to fix failing test in release-4.18 Hypershift environments.

Original Commit

Problem Fixed

The test "API LBs follow /readyz of kube-apiserver and stop sending requests before server shutdowns for external clients" is failing in Hypershift/HCP environments.

Failure symptoms:

Expected
   <string>: tail: '/var/log/kube-apiserver/audit.log' has appeared; following new file{"kind":"Event",...
to have prefix
   <string>: {"kind":"Event",

The test expects audit log lines to start with {"kind":"Event", but in Hypershift environments, the log output includes a tail: prefix from the container's log collection mechanism.

Solution

This test was removed from main because:

  1. The functionality is already covered by the auditloganalyzer test
  2. The test implementation has issues in Hypershift/HCP environments where audit logs are collected differently
  3. Removing the duplicate test eliminates the false failures

Changes

  • Removes the duplicated "external clients" graceful termination test
  • Removes unused imports (compress/gzip, io, ioutil, os, path, filepath, configv1, clihelpers)
  • 123 lines removed

Test Plan

  • Verify the test is removed in release-4.18
  • Confirm CI passes without this test
  • Verify auditloganalyzer still covers this functionality

/assign @wangke19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link
Contributor Author

wangke19 commented Mar 5, 2026

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2026

@wangke19: This pull request references OCPQE-31732 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link
Contributor Author

wangke19 commented Mar 5, 2026

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2026

@wangke19: This pull request references OCPQE-31732 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19 wangke19 changed the title OCPQE-31732:Backport: Remove duplicated graceful termination test from release-4.18 OCPBUGS-77876:Backport: Remove duplicated graceful termination test from release-4.18 Mar 5, 2026
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 5, 2026
@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-77876, which is invalid:

  • expected Jira Issue OCPBUGS-77876 to depend on a bug targeting a version in 4.19.0, 4.19.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Backport of #29930 to fix failing test in release-4.18 Hypershift environments.

Original Commit

Problem Fixed

The test "API LBs follow /readyz of kube-apiserver and stop sending requests before server shutdowns for external clients" is failing in Hypershift/HCP environments.

Failure symptoms:

Expected
   <string>: tail: '/var/log/kube-apiserver/audit.log' has appeared; following new file{"kind":"Event",...
to have prefix
   <string>: {"kind":"Event",

The test expects audit log lines to start with {"kind":"Event", but in Hypershift environments, the log output includes a tail: prefix from the container's log collection mechanism.

Solution

This test was removed from main because:

  1. The functionality is already covered by the auditloganalyzer test
  2. The test implementation has issues in Hypershift/HCP environments where audit logs are collected differently
  3. Removing the duplicate test eliminates the false failures

Changes

  • Removes the duplicated "external clients" graceful termination test
  • Removes unused imports (compress/gzip, io, ioutil, os, path, filepath, configv1, clihelpers)
  • 123 lines removed

Test Plan

  • Verify the test is removed in release-4.18
  • Confirm CI passes without this test
  • Verify auditloganalyzer still covers this functionality

/assign @wangke19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link
Contributor Author

wangke19 commented Mar 5, 2026

/jira refresh

@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-77876, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link
Contributor Author

wangke19 commented Mar 5, 2026

/jira refresh

@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-77876, which is invalid:

  • expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19.z" instead
  • expected dependent Jira Issue OCPBUGS-77878 to target a version in 4.19.0, 4.19.z, but it targets "4.18.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link
Contributor Author

wangke19 commented Mar 5, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 5, 2026
@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-77876, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-77878 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-77878 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link
Contributor Author

wangke19 commented Mar 5, 2026

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 5, 2026

@wangke19: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 43c5124 into openshift:release-4.18 Mar 5, 2026
15 checks passed
@openshift-ci-robot
Copy link

@wangke19: Jira Issue Verification Checks: Jira Issue OCPBUGS-77876
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-77876 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Summary

Backport of #29930 to fix failing test in release-4.18 Hypershift environments.

Original Commit

Problem Fixed

The test "API LBs follow /readyz of kube-apiserver and stop sending requests before server shutdowns for external clients" is failing in Hypershift/HCP environments.

Failure symptoms:

Expected
   <string>: tail: '/var/log/kube-apiserver/audit.log' has appeared; following new file{"kind":"Event",...
to have prefix
   <string>: {"kind":"Event",

The test expects audit log lines to start with {"kind":"Event", but in Hypershift environments, the log output includes a tail: prefix from the container's log collection mechanism.

Solution

This test was removed from main because:

  1. The functionality is already covered by the auditloganalyzer test
  2. The test implementation has issues in Hypershift/HCP environments where audit logs are collected differently
  3. Removing the duplicate test eliminates the false failures

Changes

  • Removes the duplicated "external clients" graceful termination test
  • Removes unused imports (compress/gzip, io, ioutil, os, path, filepath, configv1, clihelpers)
  • 123 lines removed

Test Plan

  • Verify the test is removed in release-4.18
  • Confirm CI passes without this test
  • Verify auditloganalyzer still covers this functionality

/assign @wangke19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19 wangke19 deleted the backport-remove-graceful-test-to-release-4.18 branch March 5, 2026 19:47
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.18.0-0.nightly-2026-03-06-093321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants