NE-2131: register CIO tests extension by lihongan · Pull Request #30847 · openshift/origin

lihongan · 2026-03-09T04:35:39Z

Follow up CIO: openshift/cluster-ingress-operator#1371

openshift-ci-robot · 2026-03-09T04:35:41Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

openshift-ci · 2026-03-09T04:36:17Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lihongan
Once this PR has been reviewed and has the lgtm label, please assign sosiouxme for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coderabbitai · 2026-03-09T04:36:17Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0ce4a2db-8f92-4721-a845-2d75ee85f13c

📥 Commits

Reviewing files that changed from the base of the PR and between 801c758 and 92e5812.

📒 Files selected for processing (2)

pkg/test/extensions/binary.go
test/extended/router/gatewayapi.go

💤 Files with no reviewable changes (1)

test/extended/router/gatewayapi.go

🚧 Files skipped from review as they are similar to previous changes (1)

pkg/test/extensions/binary.go

Walkthrough

Added a new test extension binary entry for cluster-ingress-operator and removed a Ginkgo-based Gateway API CRD test suite.

Changes

Cohort / File(s)	Summary
Test Extension Registry `pkg/test/extensions/binary.go`	Added a test extension binary record: `imageTag: "cluster-ingress-operator"`, `binaryPath: "/usr/bin/cluster-ingress-operator-tests-ext.gz"`.
Removed Gateway API Tests `test/extended/router/gatewayapi.go`	Deleted a Ginkgo integration test file that exercised Gateway API CRDs (presence, immutability, install/create/delete/update checks) and included a helper to synthesize CRD objects.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names	✅ Passed	PR adds test binary registry entry and removes Gateway API test suite; no dynamic test names detected.
Test Structure And Quality	✅ Passed	The PR registers a test binary extension for cluster-ingress-operator in binary.go rather than introducing new Ginkgo test implementations, so the custom test structure and quality check does not apply.
Title check	✅ Passed	The title references registering CIO (cluster-ingress-operator) tests extension, which directly corresponds to the main change of adding a new test binary entry for cluster-ingress-operator in the extensionBinaries registry.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📝 Coding Plan

Generate coding plan for human review comments

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.3)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

You can get early access to new features in CodeRabbit.

Enable the early_access setting to enable early access features such as new models, tools, and more.

lihongan · 2026-03-09T08:11:28Z

/retest-required

openshift-ci-robot · 2026-03-09T08:35:36Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

openshift-trt · 2026-03-09T15:30:56Z

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New tests seen in this PR at sha: 84ab88d

"[sig-network-edge][OTE][Jira:NE][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure CRD of experimental group is not installed" [Total: 4, Pass: 4, Fail: 0, Flake: 0]
"[sig-network-edge][OTE][Jira:NE][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure CRD of standard group can not be created" [Total: 4, Pass: 4, Fail: 0, Flake: 0]
"[sig-network-edge][OTE][Jira:NE][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure existing CRDs can not be deleted" [Total: 4, Pass: 4, Fail: 0, Flake: 0]
"[sig-network-edge][OTE][Jira:NE][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure existing CRDs can not be updated" [Total: 4, Pass: 4, Fail: 0, Flake: 0]
"[sig-network-edge][OTE][Jira:NE][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure required CRDs should already be installed" [Total: 4, Pass: 4, Fail: 0, Flake: 0]

openshift-ci-robot · 2026-03-10T02:21:49Z

@lihongan: This pull request references NE-2131 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary by CodeRabbit

Tests

Added a test binary extension to expand cluster ingress operator test coverage.

Removed an extensive Gateway API CRD integration test suite, eliminating multiple CRD-related test cases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-03-10T02:38:40Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

openshift-ci-robot · 2026-03-10T02:48:45Z

@lihongan: This pull request references NE-2131 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Follow up CIO: openshift/cluster-ingress-operator#1371

Summary by CodeRabbit

Tests

Added a test binary extension to expand cluster ingress operator test coverage.

Removed an extensive Gateway API CRD integration test suite, eliminating multiple CRD-related test cases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

lihongan · 2026-03-10T07:37:18Z

/retest-required

openshift-trt · 2026-03-10T12:13:51Z

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New tests seen in this PR at sha: 801c758

"[sig-network-edge][OTE][Jira:NE][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure CRD of experimental group is not installed" [Total: 6, Pass: 6, Fail: 0, Flake: 0]
"[sig-network-edge][OTE][Jira:NE][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure CRD of standard group can not be created" [Total: 6, Pass: 6, Fail: 0, Flake: 0]
"[sig-network-edge][OTE][Jira:NE][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure existing CRDs can not be deleted" [Total: 6, Pass: 6, Fail: 0, Flake: 0]
"[sig-network-edge][OTE][Jira:NE][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure existing CRDs can not be updated" [Total: 6, Pass: 6, Fail: 0, Flake: 0]
"[sig-network-edge][OTE][Jira:NE][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure required CRDs should already be installed" [Total: 6, Pass: 6, Fail: 0, Flake: 0]

rikatz · 2026-03-10T14:22:57Z

/hold

Per discussion with @lihongan we will fix the renames on OTE side

Tests in test/extended/router/gatewayapi.go have been migrated to the cluster-ingress-operator tests-extension binary. Removing them from origin prevents duplicate test runs.

openshift-ci-robot · 2026-03-16T02:02:48Z

@lihongan: An error was encountered searching for bug NE-2131 on the Jira server at https://issues.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


No response returned: Get "https://issues.redhat.com/rest/api/2/issue/NE-2131": GET https://issues.redhat.com/rest/api/2/issue/NE-2131 giving up after 5 attempt(s)

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

Follow up CIO: openshift/cluster-ingress-operator#1371

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-03-16T02:22:48Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

openshift-ci · 2026-03-16T06:28:06Z

@lihongan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

lihongan · 2026-03-16T07:14:12Z

/unhold
/verified by ci

The NE-2131: tests-extension: restore test names and remove metadata tracking cluster-ingress-operator#1379 got merged in 4.22.0-0.nightly-2026-03-13-065313, tests name keep same
All tests passed

openshift-ci-robot · 2026-03-16T07:14:24Z

@lihongan: This PR has been marked as verified by ci.

Details

In response to this:

/unhold
/verified by ci

The NE-2131: tests-extension: restore test names and remove metadata tracking cluster-ingress-operator#1379 got merged in 4.22.0-0.nightly-2026-03-13-065313, tests name keep same

All tests passed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

lihongan · 2026-03-16T08:16:04Z

/hold

OK, I checked the old tests name and it looks like

[sig-network][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API
CRDs and ensure required CRDs should already be installed [Suite:openshift/conformance/parallel]

but the new one with OTE doesn't have the suffix [Suite:openshift/conformance/parallel]
Let's see how to fix this

openshift-trt · 2026-03-16T11:27:40Z

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New tests seen in this PR at sha: 92e5812

"[sig-network][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure CRD of experimental group is not installed" [Total: 5, Pass: 5, Fail: 0, Flake: 0]
"[sig-network][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure CRD of standard group can not be created" [Total: 5, Pass: 5, Fail: 0, Flake: 0]
"[sig-network][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure existing CRDs can not be deleted" [Total: 5, Pass: 5, Fail: 0, Flake: 0]
"[sig-network][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure existing CRDs can not be updated" [Total: 5, Pass: 5, Fail: 0, Flake: 0]
"[sig-network][OCPFeatureGate:GatewayAPI][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API CRDs and ensure required CRDs should already be installed" [Total: 5, Pass: 5, Fail: 0, Flake: 0]

lihongan · 2026-03-16T11:55:38Z

hold until openshift/cluster-ingress-operator#1387 merged and in nightly build

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 9, 2026

openshift-ci bot requested review from p0lyn0mial and sjenning March 9, 2026 04:36

lihongan force-pushed the ote-for-cio branch from 84ab88d to 801c758 Compare March 10, 2026 02:19

lihongan changed the title ~~WIP: register CIO tests extension~~ NE-2131: register CIO tests extension Mar 10, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 10, 2026

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2026

lihongan mentioned this pull request Mar 10, 2026

[NE-2131] register CIO tests extension #30306

Closed

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2026

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 15, 2026

lihongan added 2 commits March 16, 2026 10:00

register CIO tests extension

fb7d84e

remove GatewayAPI CRD tests migrated to cluster-ingress-operator OTE

92e5812

Tests in test/extended/router/gatewayapi.go have been migrated to the cluster-ingress-operator tests-extension binary. Removing them from origin prevents duplicate test runs.

lihongan force-pushed the ote-for-cio branch from 801c758 to 92e5812 Compare March 16, 2026 02:01

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2026

openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 16, 2026

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 16, 2026

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2026

Conversation

lihongan commented Mar 9, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 9, 2026

Uh oh!

openshift-ci bot commented Mar 9, 2026

Uh oh!

coderabbitai bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

lihongan commented Mar 9, 2026

Uh oh!

openshift-ci-robot commented Mar 9, 2026

Uh oh!

openshift-trt bot commented Mar 9, 2026

Uh oh!

openshift-ci-robot commented Mar 10, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Mar 10, 2026

Uh oh!

openshift-ci-robot commented Mar 10, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

lihongan commented Mar 10, 2026

Uh oh!

openshift-trt bot commented Mar 10, 2026

Uh oh!

rikatz commented Mar 10, 2026

Uh oh!

openshift-ci-robot commented Mar 16, 2026

Uh oh!

openshift-ci-robot commented Mar 16, 2026

Uh oh!

openshift-ci bot commented Mar 16, 2026

Uh oh!

lihongan commented Mar 16, 2026

Uh oh!

openshift-ci-robot commented Mar 16, 2026

Uh oh!

lihongan commented Mar 16, 2026

Uh oh!

openshift-trt bot commented Mar 16, 2026

Uh oh!

lihongan commented Mar 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lihongan commented Mar 9, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 9, 2026 •

edited

Loading

openshift-ci-robot commented Mar 10, 2026 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Mar 10, 2026 •

edited by openshift-ci bot

Loading