Skip to content

OCPBUGS-63307: Move imagepolicy test to disruptive long-running suite#31043

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
QiWang19:long-runing-sigstoretests
Apr 22, 2026
Merged

OCPBUGS-63307: Move imagepolicy test to disruptive long-running suite#31043
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
QiWang19:long-runing-sigstoretests

Conversation

@QiWang19
Copy link
Copy Markdown
Member

@QiWang19 QiWang19 commented Apr 20, 2026

SigstoreImageVerification and SigstoreImageVerificationPKI in distuptive long-running test suite which does not monitor events should not repeat pathologically.

Summary by CodeRabbit

  • Tests
    • Updated test suite metadata to improve test categorization and organization for image policy test scenarios.

SigstoreImageVerification and SigstoreImageVerificationPKI in long-running test suite which does not monitor `events should not repeat pathologically`.

Signed-off-by: Qi Wang <qiwan@redhat.com>
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 20, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 20, 2026

Walkthrough

Updated test suite classification tags in the imagepolicy Ginkgo test suite by adding Suite:openshift/disruptive-longrunning and Disruptive labels to two describe blocks, without altering test logic or functionality.

Changes

Cohort / File(s) Summary
Test Suite Labeling
test/extended/imagepolicy/imagepolicy.go
Added Suite:openshift/disruptive-longrunning and Disruptive tags to two g.Describe blocks to classify tests as part of the disruptive-longrunning test suite.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed Pull request adds static test suite tags to Ginkgo test suites in imagepolicy.go with deterministic, stable test names containing no dynamic information.
Test Structure And Quality ✅ Passed PR modifies only test suite description tags to reclassify tests into disruptive-longrunning suite without changing test code logic, maintaining all quality requirements including proper setup/cleanup patterns and timeout configurations.
Microshift Test Compatibility ✅ Passed Tests already have OCPFeatureGate labels that conditionally gate test execution, providing protection similar to apigroup tags.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Tests do not make assumptions causing failures on Single Node OpenShift; both master and worker pools exist in SNO, pods have no multi-node scheduling constraints, and image policy APIs work identically across topologies.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only test metadata labels in test/extended/imagepolicy/imagepolicy.go without changing deployment manifests, operator code, or controllers.
Ote Binary Stdout Contract ✅ Passed PR only modifies test description strings, adding suite tags. No stdout writes at process level or module initialization.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR modifies only metadata tags on existing Ginkgo test suites, not adding new tests. The custom check applies only to newly added tests.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: moving imagepolicy tests to the disruptive long-running suite, which aligns with the file modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@QiWang19
Copy link
Copy Markdown
Member Author

/test all

@QiWang19
Copy link
Copy Markdown
Member Author

/test images

@QiWang19 QiWang19 marked this pull request as ready for review April 21, 2026 15:26
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 21, 2026
@openshift-ci openshift-ci Bot requested review from p0lyn0mial and sjenning April 21, 2026 15:26
@neisw
Copy link
Copy Markdown
Contributor

neisw commented Apr 21, 2026

/lgtm
with request to handle the test rename

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neisw, QiWang19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@neisw
Copy link
Copy Markdown
Contributor

neisw commented Apr 21, 2026

/test e2e-metal-ipi-ovn-ipv6

@QiWang19 QiWang19 changed the title Move imagepolicy test to disruptive long-running suite OCPBUGS-63307: Move imagepolicy test to disruptive long-running suite Apr 21, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 21, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@QiWang19: This pull request references Jira Issue OCPBUGS-63307, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (bgudi@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

SigstoreImageVerification and SigstoreImageVerificationPKI in distuptive long-running test suite which does not monitor events should not repeat pathologically.

Summary by CodeRabbit

  • Tests
  • Updated test suite metadata to improve test categorization and organization for image policy test scenarios.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@QiWang19
Copy link
Copy Markdown
Member Author

/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 21, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@QiWang19: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@QiWang19
Copy link
Copy Markdown
Member Author

/retest-required

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 72fbfa9 and 2 for PR HEAD 8cedde9 in total

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 90131c2 and 1 for PR HEAD 8cedde9 in total

@QiWang19
Copy link
Copy Markdown
Member Author

/retest-required

1 similar comment
@QiWang19
Copy link
Copy Markdown
Member Author

/retest-required

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD cad1b7a and 0 for PR HEAD 8cedde9 in total

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/hold

Revision 8cedde9 was retested 3 times: holding

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2026
@neisw
Copy link
Copy Markdown
Contributor

neisw commented Apr 22, 2026

/override ci/prow/e2e-aws-ovn-microshift-serial
/override ci/prow/e2e-aws-ovn-microshift

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 22, 2026

@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-aws-ovn-microshift, ci/prow/e2e-aws-ovn-microshift-serial

Details

In response to this:

/override ci/prow/e2e-aws-ovn-microshift-serial
/override ci/prow/e2e-aws-ovn-microshift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 22, 2026

@QiWang19: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@neisw
Copy link
Copy Markdown
Contributor

neisw commented Apr 22, 2026

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2026
@openshift-trt
Copy link
Copy Markdown

openshift-trt Bot commented Apr 22, 2026

Job Failure Risk Analysis for sha: 8cedde9

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift IncompleteTests
Tests for this run (28) are below the historical average (1224): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial IncompleteTests
Tests for this run (29) are below the historical average (628): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@openshift-merge-bot openshift-merge-bot Bot merged commit 6761284 into openshift:main Apr 22, 2026
21 checks passed
@openshift-ci-robot
Copy link
Copy Markdown

@QiWang19: Jira Issue OCPBUGS-63307: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-63307 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

Details

In response to this:

SigstoreImageVerification and SigstoreImageVerificationPKI in distuptive long-running test suite which does not monitor events should not repeat pathologically.

Summary by CodeRabbit

  • Tests
  • Updated test suite metadata to improve test categorization and organization for image policy test scenarios.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@QiWang19
Copy link
Copy Markdown
Member Author

/cherry-pick release-4.22

@openshift-cherrypick-robot
Copy link
Copy Markdown

@QiWang19: new pull request created: #31056

Details

In response to this:

/cherry-pick release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@QiWang19
Copy link
Copy Markdown
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

@QiWang19: Jira Issue Verification Checks: Jira Issue OCPBUGS-63307
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-63307 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

Fix included in release 5.0.0-0.nightly-2026-04-21-060302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants