OCPBUGS-84510 : fix: remove the test exceptions for kubevirt-csi-node pods

[abhay-nutanix]

Remove kubevirt-csi-node pods from the existingViolations exception list in the terminationMessagePolicy monitor test.

Summary by CodeRabbit

• Tests
  • Updated cluster monitoring exemptions to improve violation detection accuracy for container termination policies.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: e0a15571-487c-478b-8de4-9ebd7459fa03

📥 Commits

Reviewing files that changed from the base of the PR and between c12e6ce and 0299b5b.

📒 Files selected for processing (1)

• pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go

💤 Files with no reviewable changes (1)

• pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go

---

Walkthrough

Removal of the kubevirt-csi-node pod path from the exempted violations list in the cluster version operator's termination message policy monitor test. This pod will no longer be treated as a grandfathered violation when its containers lack the FallbackToLogsOnError termination message policy.

Changes

Cohort / File(s)	Summary
Termination Message Policy Monitor pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go	Removed "pods/kubevirt-csi-node" from the existingViolations exemption list for the openshift-cluster-csi-drivers namespace, causing the pod's containers to be subject to standard termination message policy validation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: removing test exceptions for kubevirt-csi-node pods from the terminationMessagePolicy monitor test, which aligns with the changeset removing this pod from the existingViolations list.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The modified file contains no Ginkgo test definitions, only a monitor test implementation that generates JUnitTestCase objects programmatically. The PR exclusively modifies the existingViolations exception list by removing a single pod path entry, which does not involve creating or modifying any test titles.
Test Structure And Quality	✅ Passed	The custom check assesses Ginkgo test code quality, but this PR modifies monitortest.go using OpenShift's custom MonitorTest framework with standard Go unit testing, not Ginkgo.
Microshift Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests, only modifies configuration in monitortest.go.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR removes a configuration entry from an exception list in a monitor test framework; no new Ginkgo e2e tests are added.
Topology-Aware Scheduling Compatibility	✅ Passed	Pull request modifies only a monitor test file to remove a pod from an exception list, with no changes to deployment manifests, operator code, controllers, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR removes a pod entry from a test violations map without modifying any stdout communication code, preserving the OTE Binary Stdout Contract.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR modifies monitor test configuration by removing an entry from existing violations list, not adding new Ginkgo e2e tests, so the IPv6/disconnected network compatibility check does not apply.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Review rate limit: 9/10 reviews remaining, refill in 6 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abhay-nutanix, coderabbitai[bot]
Once this PR has been reviewed and has the lgtm label, please assign stbenjam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[abhay-nutanix]

/retest

[openshift-ci]

@abhay-nutanix: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.