[wip]Remove the exception for OCPBUGS-23745

[hongkailiu]

OCPBUGS-23745 has been fixed and shipped with 4.15. However, the symptom is still there in 4.21 and we create OCPBUGS-66230 to track the issue.

OCPBUGS-66230 is closed as the fix is included in 4.21.0-0.nightly-2025-11-30-094855 [1].

[1]. https://redhat.atlassian.net/browse/OCPBUGS-66230?focusedCommentId=16861698

Summary by CodeRabbit

• Tests
  • Removed exception handling for monitoring cluster operator conditions during upgrade state-transition tests, allowing stricter failure detection.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: cc8e4e97-8d26-4b96-bec2-0796c574711c

📥 Commits

Reviewing files that changed from the base of the PR and between 046ab17 and 0582d8d.

📒 Files selected for processing (1)

• pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go

💤 Files with no reviewable changes (1)

• pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go

---

Walkthrough

Removed exception handling for the monitoring cluster operator during upgrade state-transition tests. Specific condition patterns previously treated as acceptable failures (referenced as OCPBUGS-23745) are no longer exempted and will now be handled by default failure logic.

Changes

Cohort / File(s)	Summary
Monitoring Operator Exception Handling pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go	Deleted dedicated exception handling for monitoring operator conditions including OperatorAvailable=False with Updating*/PlatformTasksFailed reasons and OperatorAvailable=Unknown with UpdatingPrometheusFailed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Test Structure And Quality	❓ Inconclusive	The file specified in the PR summary could not be located in the repository, making test structure assessment impossible.	Verify the repository contains the correct branch and PR changes; confirm the exact path of the modified operators.go file.

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly references the main change: removing an exception for OCPBUGS-23745. It accurately describes the primary modification to the codebase.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The modified file contains utility functions and exception handling logic, not Ginkgo test definitions, so the custom check for stable Ginkgo test names is not applicable.
Microshift Test Compatibility	✅ Passed	PR removes exception handling code, not adding new Ginkgo e2e tests, so MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR modifies existing monitor test utility functions rather than adding new Ginkgo e2e tests, making SNO compatibility check inapplicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR removes legacy exception handling from a topology-aware test file that checks ControlPlaneTopology before applying exception patterns. The removed exception for OCPBUGS-23745 was fixed in OpenShift 4.15, with related issue OCPBUGS-66230 fixed in 4.21. No new scheduling constraints are introduced.
Ote Binary Stdout Contract	✅ Passed	The pull request removes exception handling code for the monitoring cluster operator in a test library file. No stdout writes are introduced, removed, or modified, and the change does not violate the OTE Binary Stdout Contract.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR does not add new Ginkgo e2e tests; it only removes code from a monitoring utility file, so the check is not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Review rate limit: 9/10 reviews remaining, refill in 6 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: coderabbitai[bot], hongkailiu
Once this PR has been reviewed and has the lgtm label, please assign sosiouxme for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment