OCPBUGS-84516: remove openshift-machine-config-operator exemption from terminationMessagePolicy monitor

[isabella-janssen]

This removes' the MCO's exception for TRT-2084. The container policies were fixed in openshift/machine-config-operator#5993.

Summary by CodeRabbit

• Bug Fixes
  • Enhanced compliance verification to properly identify containers with non-compliant configuration settings that were previously excluded from validation checks.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@isabella-janssen: This pull request references Jira Issue OCPBUGS-84516, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This removes' the MCO's exception for TRT-2084. The container policies were fixed in openshift/machine-config-operator#5993.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: isabella-janssen
Once this PR has been reviewed and has the lgtm label, please assign petr-muller for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Walkthrough

This pull request removes a single exemption entry from a monitoring test's allowlist. The openshift-machine-config-operator namespace container exemption for containers[container-00] in the existingViolations map is deleted, causing that container's terminationMessagePolicy violations to be flagged as failures rather than grandfathered violations.

Changes

Termination Message Policy Allowlist Update

Layer / File(s)	Summary
Allowlist Configuration pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go	Removed the exemption entry for openshift-machine-config-operator pods/containers[container-00] from the existingViolations map. This container's non-compliant terminationMessagePolicy will now be reported as a test failure.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Microshift Test Compatibility	❓ Inconclusive	Unable to execute shell commands to examine the pull request changes and verify Ginkgo e2e test additions.	Provide direct access to the modified file content or git diff output to assess the changes being made.

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only removes one entry from existingViolations allowlist without modifying test name generation code or introducing new Ginkgo test declarations.
Test Structure And Quality	✅ Passed	This check is not applicable to this PR as it modifies a monitor implementation file, not Ginkgo test code.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This pull request does not add new Ginkgo e2e tests. The change modifies an existing monitoring test framework implementation by removing a line from an exemption allowlist, which is not subject to the custom check.
Topology-Aware Scheduling Compatibility	✅ Passed	This PR modifies only a test monitor framework file to remove a pre-existing violation exemption, without introducing any topology-aware scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The pull request removes one entry from the existingViolations allowlist map in CollectData() with no process-level stdout writes and no stdout contract violations introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This pull request does not add any new Ginkgo e2e tests. The change only removes an entry from an allowlist in the terminationMessagePolicy monitor configuration.
Title check	✅ Passed	The title directly and clearly describes the main change: removing the openshift-machine-config-operator exemption from the terminationMessagePolicy monitor, which aligns perfectly with the file change (1 line deletion from existingViolations allowlist).

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

@isabella-janssen: This PR was included in a payload test run from openshift/machine-config-operator#5993
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-csi

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0a5ce180-47e8-11f1-8c03-0252c16e8dd9-0

[isabella-janssen]

/hold

This should merge after openshift/machine-config-operator#5993

[isabella-janssen]

/jira refresh

[openshift-ci-robot]

@isabella-janssen: This pull request references Jira Issue OCPBUGS-84516, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@isabella-janssen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/images	76c651b	link	true	/test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.