OCPBUGS-84950: Use 41 to reorder tests by xueqzhan · Pull Request #31121 · openshift/origin

xueqzhan · 2026-05-05T01:43:35Z

/hold

For testing now.

Summary by CodeRabbit

Tests
- Test runner now separates "deployment lifecycle" tests into their own bucket. These tests are counted in logs, duplicated when a repeat count is set, included in expected totals, and executed with a dedicated monitoring interval before other test buckets.

openshift-merge-bot · 2026-05-05T01:43:37Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

openshift-ci-robot · 2026-05-05T01:43:40Z

@xueqzhan: This pull request references Jira Issue OCPBUGS-84950, which is invalid:

expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/hold

For testing now.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-05-05T01:44:00Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2c6cf681-6f9f-4a4b-8230-b1bb805d0b16

📥 Commits

Reviewing files that changed from the base of the PR and between 1477796 and a08730c.

📒 Files selected for processing (1)

pkg/test/ginkgo/cmd_runsuite.go

Walkthrough

Test scheduling now extracts tests matching "[sig-apps] Deployment should run the lifecycle of a Deployment" into a dedicated deployment lifecycle bucket, logs and counts that bucket, duplicates it when --count is set, and runs it with its own monitor interval in each execution iteration before other buckets.

Changes

Deployment Lifecycle Bucket

Layer / File(s)	Summary
Data Split `pkg/test/ginkgo/cmd_runsuite.go`	Extracts `deploymentLifecycleTests` from `kubeTests` by matching the `"[sig-apps] Deployment should run the lifecycle of a Deployment"` substring and adds it alongside other kube-derived buckets.
Logging / Reporting `pkg/test/ginkgo/cmd_runsuite.go`	Adds a log line reporting `Found %d deployment lifecycle tests`.
Duplication / Counting `pkg/test/ginkgo/cmd_runsuite.go`	When `--count != -1`, captures `originalDeploymentLifecycle`, appends copies into `deploymentLifecycleTests` per iteration, and increments `expectedTestCount` to include the new bucket.
Execution / Monitoring `pkg/test/ginkgo/cmd_runsuite.go`	In the main loop, runs a dedicated “DeploymentLifecycle” bucket each iteration: copies the bucket, records a monitor interval, executes with `parallelism`, appends results, and logs completion time before proceeding to other buckets.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 10 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Single Node Openshift (Sno) Test Compatibility	⚠️ Warning	4 new Ginkgo e2e tests added without SNO protections. Tests lack [Skipped:SingleReplicaTopology] labels or exutil.IsSingleNode() runtime checks.	Add [Skipped:SingleReplicaTopology] label to test names or guard with exutil.IsSingleNode() check. Run: /payload-job periodic-ci-openshift-release-master-ci-4.22-e2e-aws-upgrade-ovn-single-node
Title check	❓ Inconclusive	The title references a Jira issue (OCPBUGS-84950) but is vague about the actual change—'Use 41 to reorder tests' is unclear and doesn't convey what the code actually does (categorizing deployment lifecycle tests into their own bucket).	Consider revising the title to be more descriptive of the actual change, such as 'Split deployment lifecycle tests into separate bucket' to better reflect the substantive modification shown in the code.

✅ Passed checks (10 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Test names in the PR are static strings with no dynamic information. Uses fixed strings like '[sig-apps] Deployment should run the lifecycle of a Deployment' with no timestamps, UUIDs, pod/node names.
Test Structure And Quality	✅ Passed	PR modifies test orchestration code (cmd_runsuite.go), not actual Ginkgo test definitions. The custom check applies to Ginkgo test code, which is not present in these changes.
Microshift Test Compatibility	✅ Passed	This PR only modifies test scheduling in cmd_runsuite.go and does not add new Ginkgo e2e tests. The referenced test uses only standard Kubernetes APIs that are fully supported on MicroShift.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only test orchestration code (pkg/test/ginkgo/cmd_runsuite.go), not deployment manifests, operator code, or controllers. No scheduling constraints are introduced.
Ote Binary Stdout Contract	✅ Passed	No stdout contract violations detected. No fmt.Print calls, os.Stdout writes, klog usage, or uncontrolled logging. All logging uses logrus v1.9.3 (defaults to stderr).
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR modifies test orchestration logic in cmd_runsuite.go, not test definitions. It does not add new Ginkgo tests (It(), Describe(), etc.), so the custom check does not apply.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

xueqzhan · 2026-05-05T01:49:37Z

/payload-job-with-prs periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-upgrade openshift/kubernetes#2660

openshift-ci · 2026-05-05T01:49:40Z

@xueqzhan: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/acd1d010-4824-11f1-96d7-fccd400c269e-0

openshift-merge-bot · 2026-05-05T02:21:55Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

openshift-ci · 2026-05-05T06:37:11Z

@xueqzhan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-csi	`1477796`	link	true	`/test e2e-gcp-csi`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

xueqzhan · 2026-05-05T12:31:45Z

/payload-job-with-prs periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-upgrade openshift/kubernetes:2660

openshift-ci · 2026-05-05T12:31:49Z

@xueqzhan: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

xueqzhan · 2026-05-05T12:31:55Z

/payload-job periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-upgrade

openshift-ci · 2026-05-05T12:32:04Z

@xueqzhan: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/678ed890-487e-11f1-9f74-460c48509bea-0

openshift-merge-bot · 2026-05-05T13:05:21Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

xueqzhan · 2026-05-05T15:18:02Z

/payload-job-with-prs periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-upgrade openshift/kubernetes#2660

openshift-ci · 2026-05-05T15:18:06Z

@xueqzhan: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9be1f5c0-4895-11f1-8447-ace778bf3dd9-0

This reverts commit a08730c.

This reverts commit 1477796.

openshift-ci · 2026-05-05T18:15:57Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xueqzhan

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

xueqzhan · 2026-05-05T18:16:12Z

/payload-job periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-upgrade

openshift-ci · 2026-05-05T18:16:15Z

@xueqzhan: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7fa168f0-48ae-11f1-93ad-cbaa6d279788-0

xueqzhan · 2026-05-05T18:17:04Z

/payload-job-with-prs periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-upgrade openshift/kubernetes#2660

openshift-ci · 2026-05-05T18:17:08Z

@xueqzhan: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-ci-4.22-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9f10be20-48ae-11f1-8d5a-8f82a3ed3ba1-0

openshift-merge-bot · 2026-05-05T18:36:52Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

Use 41 to reorder tests

1477796

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 5, 2026

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 5, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2026

openshift-ci Bot requested review from p0lyn0mial and sjenning May 5, 2026 01:44

coderabbitai Bot approved these changes May 5, 2026

View reviewed changes

openshift-merge-bot Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label May 5, 2026

openshift-ci Bot mentioned this pull request May 5, 2026

OCPBUGS-84950: Try to deflake the deployment test by refreshing the rv used for watch openshift/kubernetes#2660

Open

Split deployment test to reproduce the issue

a08730c

xueqzhan added 2 commits May 5, 2026 14:04

Revert "Split deployment test to reproduce the issue"

8e3cb33

This reverts commit a08730c.

Revert "Use 41 to reorder tests"

8202ba6

This reverts commit 1477796.

openshift-ci Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2026

Conversation

xueqzhan commented May 5, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-merge-bot Bot commented May 5, 2026

Uh oh!

openshift-ci-robot commented May 5, 2026

Uh oh!

coderabbitai Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

❌ Failed checks (1 warning, 1 inconclusive)

Uh oh!

xueqzhan commented May 5, 2026

Uh oh!

openshift-ci Bot commented May 5, 2026

Uh oh!

openshift-merge-bot Bot commented May 5, 2026

Uh oh!

openshift-ci Bot commented May 5, 2026

Uh oh!

xueqzhan commented May 5, 2026

Uh oh!

openshift-ci Bot commented May 5, 2026

Uh oh!

xueqzhan commented May 5, 2026

Uh oh!

openshift-ci Bot commented May 5, 2026

Uh oh!

openshift-merge-bot Bot commented May 5, 2026

Uh oh!

xueqzhan commented May 5, 2026

Uh oh!

openshift-ci Bot commented May 5, 2026

Uh oh!

openshift-ci Bot commented May 5, 2026

Uh oh!

xueqzhan commented May 5, 2026

Uh oh!

openshift-ci Bot commented May 5, 2026

Uh oh!

xueqzhan commented May 5, 2026

Uh oh!

openshift-ci Bot commented May 5, 2026

Uh oh!

openshift-merge-bot Bot commented May 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

xueqzhan commented May 5, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 5, 2026 •

edited

Loading