OCPBUGS-83623: fix: add distruption tolerance for DualReplica (two-node) topology

[fracappa]

Single-replica operators on 2 node clusters experience ~53s of expected unavailability during NoExecuteTaintManager tests due to pod evition, rescheduling to the only othe control-plane node, and leader election. Add a 60s grace period for DualReplica topology, mirroring the existing SNO pattern, so this expected behaviour is not flagged as a test failure.

Summary by CodeRabbit

• New Features
  • Added support for dual replica topology mode in platform identification.
  • Enabled specialized disruption test configurations for dual replica deployments with adjusted grace parameters.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@fracappa: This pull request references Jira Issue OCPBUGS-83623, which is invalid:

• expected the bug to target either version "5.0." or "openshift-5.0.", but it targets "4.22" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Single-replica operators on 2 node clusters experience ~53s of expected unavailability during NoExecuteTaintManager tests due to pod evition, rescheduling to the only othe control-plane node, and leader election. Add a 60s grace period for DualReplica topology, mirroring the existing SNO pattern, so this expected behaviour is not flagged as a test failure.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 30c1b2d7-fae6-43c9-a848-7fe28cc796ae

📥 Commits

Reviewing files that changed from the base of the PR and between 954d227 and 11e0307.

📒 Files selected for processing (2)

• pkg/monitortestlibrary/disruptionlibrary/disruption_invariant_adapter.go
• pkg/monitortestlibrary/platformidentification/types.go

---

Walkthrough

The PR adds support for "dual" cluster topology by extending platform identification to recognize DualReplicaTopologyMode and applying specialized grace window parameters (60 seconds, 1.4 multiplier) in disruption invariant testing.

Changes

Dual Topology Support

Layer / File(s)	Summary
Topology Recognition pkg/monitortestlibrary/platformidentification/types.go	GetJobType now identifies configv1.DualReplicaTopologyMode and sets JobType.Topology to "dual".
Grace Parameter Application pkg/monitortestlibrary/disruptionlibrary/disruption_invariant_adapter.go	createDisruptionJunit applies specialized grace windows (60 seconds, 1.4x multiplier) and dual-specific detail strings when topology is "dual".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main changes: adding disruption tolerance for DualReplica topology by setting grace parameters to 60 seconds and 1.4, matching the SNO pattern mentioned in the objectives.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR modifies disruption tolerance and platform identification logic, not Ginkgo test definitions. No test names are modified or contain dynamic values.
Test Structure And Quality	✅ Passed	Check not applicable. PR makes configuration changes to disruption_invariant_adapter.go and types.go to support DualReplica topology. No Ginkgo test code was added or modified in this PR.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added in this PR. Changes only modify library code to support DualReplica topology handling. The check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added in this PR. Changes are only to library/utility files (disruption_invariant_adapter.go and types.go) that support DualReplica topology. The check does not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	PR adds topology-aware handling for DualReplica by recognizing it and applying appropriate 60s grace periods. No scheduling constraints introduced.
Ote Binary Stdout Contract	✅ Passed	Changes are in library code (no process-level functions). No stdout writes detected. Only variable assignments and conditional logic for DualReplica topology handling.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR does not add any Ginkgo e2e tests. It only modifies library files to support DualReplica topology configuration. The check is not applicable.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fracappa
Once this PR has been reviewed and has the lgtm label, please assign xueqzhan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-ci]

@fracappa: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere-ovn-upi	11e0307	link	true	/test e2e-vsphere-ovn-upi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.